Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-26 Thread Stefan Hajnoczi
On Mon, Mar 17, 2014 at 03:28:08PM +0100, Laszlo Ersek wrote: On 03/17/14 07:02, Dave Airlie wrote: So I'm looking at how best to do virtio gpu device error reporting, and how to deal with illegal stuff, I've two levels of errors I want to support, a) unrecoverable or bad guest

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-26 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 20 March 2014 06:39, Markus Armbruster arm...@redhat.com wrote: Time to cease the practice. Will be hard as long as the code is chock-full of bad examples. I've been consistently rejecting new instances of guest triggerable exit() or

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-21 Thread Yan Vugenfirer
On Mar 20, 2014, at 8:51 AM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Mar 19, 2014 at 11:04:19AM +1030, Rusty Russell wrote: Dave Airlie airl...@gmail.com writes: So I'm looking at how best to do virtio gpu device error reporting, and how to deal with illegal stuff, I've two

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-20 Thread Michael S. Tsirkin
On Wed, Mar 19, 2014 at 11:04:19AM +1030, Rusty Russell wrote: Dave Airlie airl...@gmail.com writes: So I'm looking at how best to do virtio gpu device error reporting, and how to deal with illegal stuff, I've two levels of errors I want to support, a) unrecoverable or bad guest

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-20 Thread Markus Armbruster
Rusty Russell ru...@rustcorp.com.au writes: Markus Armbruster arm...@redhat.com writes: Rusty Russell ru...@rustcorp.com.au writes: The litmus test: does *your* guest handle failures other than by giving up on the device? If so, sure, you need to have a sane error-reporting strategy. Err,

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-20 Thread Peter Maydell
On 20 March 2014 06:39, Markus Armbruster arm...@redhat.com wrote: Time to cease the practice. Will be hard as long as the code is chock-full of bad examples. I've been consistently rejecting new instances of guest triggerable exit() or abort() in code review when I see them for at least the

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-19 Thread Markus Armbruster
Rusty Russell ru...@rustcorp.com.au writes: Dave Airlie airl...@gmail.com writes: So I'm looking at how best to do virtio gpu device error reporting, and how to deal with illegal stuff, I've two levels of errors I want to support, a) unrecoverable or bad guest kernel programming errors,

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-19 Thread Rusty Russell
Markus Armbruster arm...@redhat.com writes: Rusty Russell ru...@rustcorp.com.au writes: The litmus test: does *your* guest handle failures other than by giving up on the device? If so, sure, you need to have a sane error-reporting strategy. Err, isn't this a circular argument? No need for

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-18 Thread Kevin Wolf
Am 17.03.2014 um 15:49 hat Laszlo Ersek geschrieben: On 03/17/14 15:40, Peter Maydell wrote: On 17 March 2014 14:28, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 07:02, Dave Airlie wrote: The main reason I'm considering this stuff is for security reasons if the guest asks for

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-18 Thread Rusty Russell
Dave Airlie airl...@gmail.com writes: So I'm looking at how best to do virtio gpu device error reporting, and how to deal with illegal stuff, I've two levels of errors I want to support, a) unrecoverable or bad guest kernel programming errors, The QEMU standard approach is to exit at this

[Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Dave Airlie
So I'm looking at how best to do virtio gpu device error reporting, and how to deal with illegal stuff, I've two levels of errors I want to support, a) unrecoverable or bad guest kernel programming errors, b) per 3D context errors from the renderer backend, (b) I can easily report in an event

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Laszlo Ersek
On 03/17/14 07:02, Dave Airlie wrote: So I'm looking at how best to do virtio gpu device error reporting, and how to deal with illegal stuff, I've two levels of errors I want to support, a) unrecoverable or bad guest kernel programming errors, b) per 3D context errors from the renderer

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Peter Maydell
On 17 March 2014 14:28, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 07:02, Dave Airlie wrote: The main reason I'm considering this stuff is for security reasons if the guest asks for something really illegal or crazy what should the expected behaviour of the host be? (at least secure I

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Laszlo Ersek
On 03/17/14 15:40, Peter Maydell wrote: On 17 March 2014 14:28, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 07:02, Dave Airlie wrote: The main reason I'm considering this stuff is for security reasons if the guest asks for something really illegal or crazy what should the expected

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Gerd Hoffmann
On Mo, 2014-03-17 at 16:02 +1000, Dave Airlie wrote: So I'm looking at how best to do virtio gpu device error reporting, and how to deal with illegal stuff, I've two levels of errors I want to support, a) unrecoverable or bad guest kernel programming errors, b) per 3D context errors

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Peter Maydell
On 17 March 2014 14:49, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 15:40, Peter Maydell wrote: On 17 March 2014 14:28, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 07:02, Dave Airlie wrote: The main reason I'm considering this stuff is for security reasons if the guest asks for

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Gerd Hoffmann
On Mo, 2014-03-17 at 15:49 +0100, Laszlo Ersek wrote: On 03/17/14 15:40, Peter Maydell wrote: On 17 March 2014 14:28, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 07:02, Dave Airlie wrote: The main reason I'm considering this stuff is for security reasons if the guest asks for

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Richard W.M. Jones
On Mon, Mar 17, 2014 at 02:40:09PM +, Peter Maydell wrote: On 17 March 2014 14:28, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 07:02, Dave Airlie wrote: The main reason I'm considering this stuff is for security reasons if the guest asks for something really illegal or crazy what

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Richard W.M. Jones
On Mon, Mar 17, 2014 at 02:57:41PM +, Richard W.M. Jones wrote: On Mon, Mar 17, 2014 at 02:40:09PM +, Peter Maydell wrote: On 17 March 2014 14:28, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 07:02, Dave Airlie wrote: The main reason I'm considering this stuff is for

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Andreas Färber
Am 17.03.2014 15:49, schrieb Laszlo Ersek: On 03/17/14 15:40, Peter Maydell wrote: On 17 March 2014 14:28, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 07:02, Dave Airlie wrote: The main reason I'm considering this stuff is for security reasons if the guest asks for something really