Re: [RFC PATCH] arm: force flag recalculation when messing with DAIF

2022-02-07 Thread Peter Maydell
On Wed, 2 Feb 2022 at 12:24, Alex Bennée wrote: > > The recently introduced debug tests in kvm-unit-tests exposed an error > in our handling of singlestep cause by stale hflags. This is caught by > --enable-debug-tcg when running the tests. > > Signed-off-by: Alex Bennée > Cc: Richard Henderson

Re: [RFC PATCH] arm: force flag recalculation when messing with DAIF

2022-02-05 Thread Richard Henderson
On 2/2/22 23:23, Alex Bennée wrote: The recently introduced debug tests in kvm-unit-tests exposed an error in our handling of singlestep cause by stale hflags. This is caught by --enable-debug-tcg when running the tests. You could mention that PSTATE_D is used by aa64_generate_debug_exceptions.

Re: [RFC PATCH] arm: force flag recalculation when messing with DAIF

2022-02-02 Thread Andrew Jones
On Wed, Feb 02, 2022 at 12:23:53PM +, Alex Bennée wrote: > The recently introduced debug tests in kvm-unit-tests exposed an error > in our handling of singlestep cause by stale hflags. This is caught by > --enable-debug-tcg when running the tests. > > Signed-off-by: Alex Bennée > Cc: Richard

[RFC PATCH] arm: force flag recalculation when messing with DAIF

2022-02-02 Thread Alex Bennée
The recently introduced debug tests in kvm-unit-tests exposed an error in our handling of singlestep cause by stale hflags. This is caught by --enable-debug-tcg when running the tests. Signed-off-by: Alex Bennée Cc: Richard Henderson Cc: Andrew Jones --- target/arm/helper-a64.c | 2 ++ 1 file