Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-16 Thread Paolo Bonzini
On 16/09/20 13:25, Stefan Hajnoczi wrote: >> No, only developers need jq and only if they add configure options. >> Using Python would certainly be possible, though probably it wouldn't be >> a one-liner as for jq. > I see. Avoiding the dependency would be nice but only if the alternative > is

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-16 Thread Stefan Hajnoczi
On Mon, Sep 14, 2020 at 12:27:59PM +0200, Paolo Bonzini wrote: > On 14/09/20 11:57, Stefan Hajnoczi wrote: > > On Sun, Sep 13, 2020 at 12:05:31PM +0200, Paolo Bonzini wrote: > >> - because we parse command-line options before meson is available, > >> the introspection output is stored in the

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-16 Thread Stefan Hajnoczi
On Mon, Sep 14, 2020 at 06:00:11PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Mon, Sep 14, 2020 at 5:58 PM Stefan Hajnoczi wrote: > > > > On Sun, Sep 13, 2020 at 12:05:31PM +0200, Paolo Bonzini wrote: > > > - because we parse command-line options before meson is available, > > > the introspection

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-14 Thread Paolo Bonzini
On 14/09/20 11:12, Daniel P. Berrangé wrote: > IMHO we should stay as far away from Perl as possible, and I say this as > someone who enjoys writing Perl scripts ! Perl is a significant barrier > to entry for potential contributors, because it just doesn't have the > wide knowledge base that it

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-14 Thread Paolo Bonzini
On 14/09/20 11:57, Stefan Hajnoczi wrote: > On Sun, Sep 13, 2020 at 12:05:31PM +0200, Paolo Bonzini wrote: >> - because we parse command-line options before meson is available, >> the introspection output is stored in the source tree. The output >> is slightly modified using the "jq" tool in

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-14 Thread Yonggang Luo
On Mon, Sep 14, 2020 at 5:58 PM Stefan Hajnoczi wrote: > > On Sun, Sep 13, 2020 at 12:05:31PM +0200, Paolo Bonzini wrote: > > - because we parse command-line options before meson is available, > > the introspection output is stored in the source tree. The output > > is slightly modified using

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-14 Thread Stefan Hajnoczi
On Sun, Sep 13, 2020 at 12:05:31PM +0200, Paolo Bonzini wrote: > - because we parse command-line options before meson is available, > the introspection output is stored in the source tree. The output > is slightly modified using the "jq" tool in order to ensure that it's > stable and that

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-14 Thread Daniel P . Berrangé
On Sun, Sep 13, 2020 at 12:05:31PM +0200, Paolo Bonzini wrote: > Right now meson_options.txt lists less than a dozen options, but about > 40 more could come as configure tests are converted and moved to > meson.build. Each option needs code in configure to parse it and pass > the option down to

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-13 Thread Paolo Bonzini
On 13/09/20 12:15, 罗勇刚(Yonggang Luo) wrote: > > I am confusing about this? we were converting configure to meson, > and python is a force dependencies, why we need rewrite the script in > Perl? If we wanna build qemu, the first thing we need to install is > python+meson, so there is no need

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-13 Thread Yonggang Luo
On Sun, Sep 13, 2020 at 6:07 PM Paolo Bonzini wrote: > Right now meson_options.txt lists less than a dozen options, but about > 40 more could come as configure tests are converted and moved to > meson.build. Each option needs code in configure to parse it and pass > the option down to Meson as

[RFC PATCH 0/3] Automatically convert configure options to meson build options

2020-09-13 Thread Paolo Bonzini
Right now meson_options.txt lists less than a dozen options, but about 40 more could come as configure tests are converted and moved to meson.build. Each option needs code in configure to parse it and pass the option down to Meson as a -D command-line argument; in addition the default must be