Re: [RFC PATCH 12/16] hw/arm/smmuv3: Add VMID to tlb tagging

2023-02-16 Thread Eric Auger
On 2/16/23 14:53, Mostafa Saleh wrote: > Hi Eric, > > On Thu, Feb 16, 2023 at 11:17:34AM +0100, Eric Auger wrote: >>> } >>> >>> -*key = smmu_get_iotlb_key(cfg->asid, new->entry.iova, tg, new->level); >>> +*key = smmu_get_iotlb_key(cfg->asid, cfg->s2cfg.vmid, new->entry.iova, >>>

Re: [RFC PATCH 12/16] hw/arm/smmuv3: Add VMID to tlb tagging

2023-02-16 Thread Mostafa Saleh
Hi Eric, On Thu, Feb 16, 2023 at 11:17:34AM +0100, Eric Auger wrote: > > } > > > > -*key = smmu_get_iotlb_key(cfg->asid, new->entry.iova, tg, new->level); > > +*key = smmu_get_iotlb_key(cfg->asid, cfg->s2cfg.vmid, new->entry.iova, > > + tg, new->level);

Re: [RFC PATCH 12/16] hw/arm/smmuv3: Add VMID to tlb tagging

2023-02-16 Thread Mostafa Saleh
Hi Jean, Thanks for taking the time to check the patches. On Wed, Feb 15, 2023 at 07:47:18PM +, Jean-Philippe Brucker wrote: > > diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c > > index 541c427684..028a60949a 100644 > > --- a/hw/arm/smmu-common.c > > +++ b/hw/arm/smmu-common.c > >

Re: [RFC PATCH 12/16] hw/arm/smmuv3: Add VMID to tlb tagging

2023-02-16 Thread Eric Auger
Hi, On 2/5/23 10:44, Mostafa Saleh wrote: > Allow TLB to be tagged with VMID. > > If stage-1 is only supported, VMID is set to -1 and ignored from STE > and CMD_TLBI_NH* cmds. > > Signed-off-by: Mostafa Saleh > --- > hw/arm/smmu-common.c | 24 +++- >

Re: [RFC PATCH 12/16] hw/arm/smmuv3: Add VMID to tlb tagging

2023-02-15 Thread Jean-Philippe Brucker
Hi Mostafa, On Sun, Feb 05, 2023 at 09:44:07AM +, Mostafa Saleh wrote: > Allow TLB to be tagged with VMID. > > If stage-1 is only supported, VMID is set to -1 and ignored from STE > and CMD_TLBI_NH* cmds. > > Signed-off-by: Mostafa Saleh > --- > hw/arm/smmu-common.c | 24

[RFC PATCH 12/16] hw/arm/smmuv3: Add VMID to tlb tagging

2023-02-05 Thread Mostafa Saleh
Allow TLB to be tagged with VMID. If stage-1 is only supported, VMID is set to -1 and ignored from STE and CMD_TLBI_NH* cmds. Signed-off-by: Mostafa Saleh --- hw/arm/smmu-common.c | 24 +++- hw/arm/smmu-internal.h | 2 ++ hw/arm/smmuv3.c | 12