Re: [RFC PATCH v2] meson: Only generate trace files for selected targets

2021-03-09 Thread Philippe Mathieu-Daudé
On 3/9/21 11:26 AM, Paolo Bonzini wrote: > On 09/03/21 09:41, Claudio Fontana wrote: >> In any case, I agree that just recursing all directories in target/ >> looking for trace.h / traceevents files could be better. > > Using the directory structure to find source files is a bad idea because >

Re: [RFC PATCH v2] meson: Only generate trace files for selected targets

2021-03-09 Thread Claudio Fontana
On 3/9/21 11:26 AM, Paolo Bonzini wrote: > On 09/03/21 09:41, Claudio Fontana wrote: >> In any case, I agree that just recursing all directories in target/ >> looking for trace.h / traceevents files could be better. > > Using the directory structure to find source files is a bad idea because >

Re: [RFC PATCH v2] meson: Only generate trace files for selected targets

2021-03-09 Thread Paolo Bonzini
On 09/03/21 09:41, Claudio Fontana wrote: In any case, I agree that just recursing all directories in target/ looking for trace.h / traceevents files could be better. Using the directory structure to find source files is a bad idea because you don't notice that you haven't "git add"ed a file

Re: [RFC PATCH v2] meson: Only generate trace files for selected targets

2021-03-09 Thread Philippe Mathieu-Daudé
On 3/9/21 9:41 AM, Claudio Fontana wrote: > On 3/8/21 6:48 PM, Philippe Mathieu-Daudé wrote: >> On 3/8/21 5:46 PM, Stefan Hajnoczi wrote: >>> On Wed, Feb 24, 2021 at 10:35:15PM +0100, Philippe Mathieu-Daudé wrote: We don't need to generate trace files for targets we are not building.

Re: [RFC PATCH v2] meson: Only generate trace files for selected targets

2021-03-09 Thread Claudio Fontana
On 3/8/21 6:48 PM, Philippe Mathieu-Daudé wrote: > On 3/8/21 5:46 PM, Stefan Hajnoczi wrote: >> On Wed, Feb 24, 2021 at 10:35:15PM +0100, Philippe Mathieu-Daudé wrote: >>> We don't need to generate trace files for targets we >>> are not building. Restrict the the ones selected. >>> >>>

Re: [RFC PATCH v2] meson: Only generate trace files for selected targets

2021-03-08 Thread Philippe Mathieu-Daudé
On 3/8/21 5:46 PM, Stefan Hajnoczi wrote: > On Wed, Feb 24, 2021 at 10:35:15PM +0100, Philippe Mathieu-Daudé wrote: >> We don't need to generate trace files for targets we >> are not building. Restrict the the ones selected. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> meson.build | 16

Re: [RFC PATCH v2] meson: Only generate trace files for selected targets

2021-03-08 Thread Stefan Hajnoczi
On Wed, Feb 24, 2021 at 10:35:15PM +0100, Philippe Mathieu-Daudé wrote: > We don't need to generate trace files for targets we > are not building. Restrict the the ones selected. > > Signed-off-by: Philippe Mathieu-Daudé > --- > meson.build | 16 > 1 file changed, 8

[RFC PATCH v2] meson: Only generate trace files for selected targets

2021-02-24 Thread Philippe Mathieu-Daudé
We don't need to generate trace files for targets we are not building. Restrict the the ones selected. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/meson.build b/meson.build index