Re: [RFC PATCH v2 5/5] target/arm/cpu: Add the kvm-no-adjvtime CPU property

2020-02-06 Thread Andrew Jones
On Thu, Feb 06, 2020 at 11:46:49PM +0100, Philippe Mathieu-Daudé wrote: > On 2/6/20 1:40 PM, Andrew Jones wrote: > > On Thu, Feb 06, 2020 at 01:08:53PM +0100, Philippe Mathieu-Daudé wrote: > > ... > > > > +/* KVM VCPU properties should be prefixed with "kvm-". */ > > > > +void

Re: [RFC PATCH v2 5/5] target/arm/cpu: Add the kvm-no-adjvtime CPU property

2020-02-06 Thread Philippe Mathieu-Daudé
On 2/6/20 1:40 PM, Andrew Jones wrote: On Thu, Feb 06, 2020 at 01:08:53PM +0100, Philippe Mathieu-Daudé wrote: ... +/* KVM VCPU properties should be prefixed with "kvm-". */ +void kvm_arm_add_vcpu_properties(Object *obj) +{ +if (!kvm_enabled()) { This can't happen, right? Can we turn that

Re: [RFC PATCH v2 5/5] target/arm/cpu: Add the kvm-no-adjvtime CPU property

2020-02-06 Thread Andrew Jones
On Thu, Feb 06, 2020 at 01:08:53PM +0100, Philippe Mathieu-Daudé wrote: ... > > +/* KVM VCPU properties should be prefixed with "kvm-". */ > > +void kvm_arm_add_vcpu_properties(Object *obj) > > +{ > > +if (!kvm_enabled()) { > > This can't happen, right? Can we turn that into an assertion, or

Re: [RFC PATCH v2 5/5] target/arm/cpu: Add the kvm-no-adjvtime CPU property

2020-02-06 Thread Philippe Mathieu-Daudé
Hi Drew, On Thu, Dec 12, 2019 at 7:27 PM Andrew Jones wrote: > kvm-no-adjvtime is a KVM specific CPU property and a first of its kind. > To accommodate it we also add kvm_arm_add_vcpu_properties() and a > KVM specific CPU properties description to the CPU features document. > > Signed-off-by:

Re: [RFC PATCH v2 5/5] target/arm/cpu: Add the kvm-no-adjvtime CPU property

2020-01-20 Thread Andrew Jones
On Mon, Dec 16, 2019 at 03:06:57PM +, Peter Maydell wrote: > Incidentally, if I understand things correctly, for TCG the > behaviour is (and has always been) that VM-stopped time is > not counted, because we run the emulated versions of these counters > off QEMU_CLOCK_VIRTUAL. So having the

Re: [RFC PATCH v2 5/5] target/arm/cpu: Add the kvm-no-adjvtime CPU property

2019-12-16 Thread Peter Maydell
On Mon, 16 Dec 2019 at 16:53, Andrew Jones wrote: > > On Mon, Dec 16, 2019 at 03:06:57PM +, Peter Maydell wrote: > > This phrasing reads a bit confusingly to me. What I would usually expect > > is that you get > > name-of-option Description of what the option does. > > > > But

Re: [RFC PATCH v2 5/5] target/arm/cpu: Add the kvm-no-adjvtime CPU property

2019-12-16 Thread Andrew Jones
On Mon, Dec 16, 2019 at 03:06:57PM +, Peter Maydell wrote: > On Thu, 12 Dec 2019 at 17:33, Andrew Jones wrote: > > > > kvm-no-adjvtime is a KVM specific CPU property and a first of its kind. > > To accommodate it we also add kvm_arm_add_vcpu_properties() and a > > KVM specific CPU properties

Re: [RFC PATCH v2 5/5] target/arm/cpu: Add the kvm-no-adjvtime CPU property

2019-12-16 Thread Peter Maydell
On Thu, 12 Dec 2019 at 17:33, Andrew Jones wrote: > > kvm-no-adjvtime is a KVM specific CPU property and a first of its kind. > To accommodate it we also add kvm_arm_add_vcpu_properties() and a > KVM specific CPU properties description to the CPU features document. > > Signed-off-by: Andrew Jones

[RFC PATCH v2 5/5] target/arm/cpu: Add the kvm-no-adjvtime CPU property

2019-12-12 Thread Andrew Jones
kvm-no-adjvtime is a KVM specific CPU property and a first of its kind. To accommodate it we also add kvm_arm_add_vcpu_properties() and a KVM specific CPU properties description to the CPU features document. Signed-off-by: Andrew Jones --- docs/arm-cpu-features.rst | 31