Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On 2021/3/12 2:53 下午, Bin Meng wrote: On Fri, Mar 12, 2021 at 2:50 PM Jason Wang wrote: On 2021/3/12 2:28 下午, Bin Meng wrote: On Fri, Mar 12, 2021 at 2:23 PM Jason Wang wrote: On 2021/3/11 6:27 下午, Bin Meng wrote: On Thu, Mar 11, 2021 at 6:22 PM Peter Maydell wrote: On Thu, 11 Mar

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Fri, Mar 12, 2021 at 2:50 PM Jason Wang wrote: > > > On 2021/3/12 2:28 下午, Bin Meng wrote: > > On Fri, Mar 12, 2021 at 2:23 PM Jason Wang wrote: > >> > >> On 2021/3/11 6:27 下午, Bin Meng wrote: > >>> On Thu, Mar 11, 2021 at 6:22 PM Peter Maydell > >>> wrote: > On Thu, 11 Mar 2021 at

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On 2021/3/12 2:28 下午, Bin Meng wrote: On Fri, Mar 12, 2021 at 2:23 PM Jason Wang wrote: On 2021/3/11 6:27 下午, Bin Meng wrote: On Thu, Mar 11, 2021 at 6:22 PM Peter Maydell wrote: On Thu, 11 Mar 2021 at 09:58, Bin Meng wrote: On Thu, Mar 11, 2021 at 5:43 PM Peter Maydell wrote: On

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Fri, Mar 12, 2021 at 2:23 PM Jason Wang wrote: > > > On 2021/3/11 6:27 下午, Bin Meng wrote: > > On Thu, Mar 11, 2021 at 6:22 PM Peter Maydell > > wrote: > >> On Thu, 11 Mar 2021 at 09:58, Bin Meng wrote: > >>> On Thu, Mar 11, 2021 at 5:43 PM Peter Maydell > >>> wrote: > On Thu, 11 Mar

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On 2021/3/9 8:30 下午, Yan Vugenfirer wrote: On 9 Mar 2021, at 12:13 PM, Peter Maydell > wrote: On Tue, 9 Mar 2021 at 09:01, Bin Meng > wrote: Hi Jason, On Tue, Mar 9, 2021 at 5:00 PM Bin Meng > wrote:

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On 2021/3/11 6:27 下午, Bin Meng wrote: On Thu, Mar 11, 2021 at 6:22 PM Peter Maydell wrote: On Thu, 11 Mar 2021 at 09:58, Bin Meng wrote: On Thu, Mar 11, 2021 at 5:43 PM Peter Maydell wrote: On Thu, 11 Mar 2021 at 03:01, Jason Wang wrote: And after a discussion 10 years ago [1]. Michael

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Thu, Mar 11, 2021 at 6:22 PM Peter Maydell wrote: > > On Thu, 11 Mar 2021 at 09:58, Bin Meng wrote: > > > > On Thu, Mar 11, 2021 at 5:43 PM Peter Maydell > > wrote: > > > > > > On Thu, 11 Mar 2021 at 03:01, Jason Wang wrote: > > > > And after a discussion 10 years ago [1]. Michael (cced)

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Thu, 11 Mar 2021 at 09:58, Bin Meng wrote: > > On Thu, Mar 11, 2021 at 5:43 PM Peter Maydell > wrote: > > > > On Thu, 11 Mar 2021 at 03:01, Jason Wang wrote: > > > And after a discussion 10 years ago [1]. Michael (cced) seems to want to > > > keep the padding logic in the NIC itself

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Thu, Mar 11, 2021 at 5:43 PM Peter Maydell wrote: > > On Thu, 11 Mar 2021 at 03:01, Jason Wang wrote: > > > > > > On 2021/3/9 6:13 下午, Peter Maydell wrote: > > > On Tue, 9 Mar 2021 at 09:01, Bin Meng wrote: > > >> Ah, so we want this: > > >> > > >> if (sender->info->type !=

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Thu, 11 Mar 2021 at 03:01, Jason Wang wrote: > > > On 2021/3/9 6:13 下午, Peter Maydell wrote: > > On Tue, 9 Mar 2021 at 09:01, Bin Meng wrote: > >> Ah, so we want this: > >> > >> if (sender->info->type != NET_CLIENT_DRIVER_NIC) > >> > >> correct? > > No, option (2) is "always pad short

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Thu, Mar 11, 2021 at 11:33 AM Jason Wang wrote: > > > On 2021/3/11 11:12 上午, Bin Meng wrote: > > On Thu, Mar 11, 2021 at 11:01 AM Jason Wang wrote: > >> > >> On 2021/3/9 6:13 下午, Peter Maydell wrote: > >>> On Tue, 9 Mar 2021 at 09:01, Bin Meng wrote: > Hi Jason, > > On Tue,

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On 2021/3/11 11:12 上午, Bin Meng wrote: On Thu, Mar 11, 2021 at 11:01 AM Jason Wang wrote: On 2021/3/9 6:13 下午, Peter Maydell wrote: On Tue, 9 Mar 2021 at 09:01, Bin Meng wrote: Hi Jason, On Tue, Mar 9, 2021 at 5:00 PM Bin Meng wrote: Hi Jason, On Tue, Mar 9, 2021 at 4:57 PM Jason

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Thu, Mar 11, 2021 at 11:01 AM Jason Wang wrote: > > > On 2021/3/9 6:13 下午, Peter Maydell wrote: > > On Tue, 9 Mar 2021 at 09:01, Bin Meng wrote: > >> Hi Jason, > >> > >> On Tue, Mar 9, 2021 at 5:00 PM Bin Meng wrote: > >>> Hi Jason, > >>> > >>> On Tue, Mar 9, 2021 at 4:57 PM Jason Wang

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On 2021/3/9 6:13 下午, Peter Maydell wrote: On Tue, 9 Mar 2021 at 09:01, Bin Meng wrote: Hi Jason, On Tue, Mar 9, 2021 at 5:00 PM Bin Meng wrote: Hi Jason, On Tue, Mar 9, 2021 at 4:57 PM Jason Wang wrote: On 2021/3/9 4:35 下午, Bin Meng wrote: Hi Jason, On Tue, Mar 9, 2021 at 4:23 PM

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

> On 9 Mar 2021, at 12:13 PM, Peter Maydell wrote: > > On Tue, 9 Mar 2021 at 09:01, Bin Meng > wrote: >> >> Hi Jason, >> >> On Tue, Mar 9, 2021 at 5:00 PM Bin Meng wrote: >>> >>> Hi Jason, >>> >>> On Tue, Mar 9, 2021 at 4:57 PM Jason Wang wrote:

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Tue, Mar 9, 2021 at 8:30 PM Yan Vugenfirer wrote: > > > > On 9 Mar 2021, at 12:13 PM, Peter Maydell wrote: > > On Tue, 9 Mar 2021 at 09:01, Bin Meng wrote: > > > Hi Jason, > > On Tue, Mar 9, 2021 at 5:00 PM Bin Meng wrote: > > > Hi Jason, > > On Tue, Mar 9, 2021 at 4:57 PM Jason Wang

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

Hi Peter, On Tue, Mar 9, 2021 at 6:13 PM Peter Maydell wrote: > > On Tue, 9 Mar 2021 at 09:01, Bin Meng wrote: > > > > Hi Jason, > > > > On Tue, Mar 9, 2021 at 5:00 PM Bin Meng wrote: > > > > > > Hi Jason, > > > > > > On Tue, Mar 9, 2021 at 4:57 PM Jason Wang wrote: > > > > > > > > > > > > On

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Tue, 9 Mar 2021 at 09:01, Bin Meng wrote: > > Hi Jason, > > On Tue, Mar 9, 2021 at 5:00 PM Bin Meng wrote: > > > > Hi Jason, > > > > On Tue, Mar 9, 2021 at 4:57 PM Jason Wang wrote: > > > > > > > > > On 2021/3/9 4:35 下午, Bin Meng wrote: > > > > Hi Jason, > > > > > > > > On Tue, Mar 9, 2021

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

Hi Jason, On Tue, Mar 9, 2021 at 5:00 PM Bin Meng wrote: > > Hi Jason, > > On Tue, Mar 9, 2021 at 4:57 PM Jason Wang wrote: > > > > > > On 2021/3/9 4:35 下午, Bin Meng wrote: > > > Hi Jason, > > > > > > On Tue, Mar 9, 2021 at 4:23 PM Jason Wang wrote: > > >> > > >> On 2021/3/8 6:22 下午, Peter

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

Hi Jason, On Tue, Mar 9, 2021 at 4:57 PM Jason Wang wrote: > > > On 2021/3/9 4:35 下午, Bin Meng wrote: > > Hi Jason, > > > > On Tue, Mar 9, 2021 at 4:23 PM Jason Wang wrote: > >> > >> On 2021/3/8 6:22 下午, Peter Maydell wrote: > >>> On Mon, 8 Mar 2021 at 03:48, Jason Wang wrote: > Do we

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On 2021/3/9 4:35 下午, Bin Meng wrote: Hi Jason, On Tue, Mar 9, 2021 at 4:23 PM Jason Wang wrote: On 2021/3/8 6:22 下午, Peter Maydell wrote: On Mon, 8 Mar 2021 at 03:48, Jason Wang wrote: Do we need to care about other type of networking backends? E.g socket. Or at least we should keep

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

Hi Jason, On Tue, Mar 9, 2021 at 4:23 PM Jason Wang wrote: > > > On 2021/3/8 6:22 下午, Peter Maydell wrote: > > On Mon, 8 Mar 2021 at 03:48, Jason Wang wrote: > >> Do we need to care about other type of networking backends? E.g socket. > >> > >> Or at least we should keep the padding logic if we

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On 2021/3/8 6:22 下午, Peter Maydell wrote: On Mon, 8 Mar 2021 at 03:48, Jason Wang wrote: Do we need to care about other type of networking backends? E.g socket. Or at least we should keep the padding logic if we can't audit all of the backends. I think the key thing we need to do here is

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Mon, 8 Mar 2021 at 03:48, Jason Wang wrote: > Do we need to care about other type of networking backends? E.g socket. > > Or at least we should keep the padding logic if we can't audit all of > the backends. I think the key thing we need to do here is make a decision and be clear about what

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On Mon, Mar 8, 2021 at 11:48 AM Jason Wang wrote: > > > On 2021/3/4 3:11 上午, Philippe Mathieu-Daudé wrote: > > From: Bin Meng > > > > The minimum Ethernet frame length is 60 bytes. For short frames with > > smaller length like ARP packets (only 42 bytes), on a real world NIC > > it can choose

Re: [RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

On 2021/3/4 3:11 上午, Philippe Mathieu-Daudé wrote: From: Bin Meng The minimum Ethernet frame length is 60 bytes. For short frames with smaller length like ARP packets (only 42 bytes), on a real world NIC it can choose either padding its length to the minimum required 60 bytes, or sending it

[RFC PATCH v3 02/10] net: Pad short frames to minimum size before send from SLiRP/TAP

From: Bin Meng The minimum Ethernet frame length is 60 bytes. For short frames with smaller length like ARP packets (only 42 bytes), on a real world NIC it can choose either padding its length to the minimum required 60 bytes, or sending it out directly to the wire. Such behavior can be