Re: [RFC PATCH v3 27/34] Hexagon (target/hexagon) instruction classes

2020-08-30 Thread Richard Henderson
On 8/30/20 1:04 PM, Taylor Simpson wrote: > So, this should be CamelCase? I should be able to fix all of them. Yes, they should. Thanks. r~

RE: [RFC PATCH v3 27/34] Hexagon (target/hexagon) instruction classes

2020-08-30 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Friday, August 28, 2020 7:37 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PA

Re: [RFC PATCH v3 27/34] Hexagon (target/hexagon) instruction classes

2020-08-28 Thread Richard Henderson
On 8/18/20 8:50 AM, Taylor Simpson wrote: > +} iclass_t; ... > +extern const char *find_iclass_slots(opcode_t opcode, int itype); ... > +typedef struct { > +const char * const slots; > +} iclass_info_t; I'll note that you aren't following our CODING_STYLE for types. Which of these need to

[RFC PATCH v3 27/34] Hexagon (target/hexagon) instruction classes

2020-08-18 Thread Taylor Simpson
Determine legal VLIW slots for each instruction Signed-off-by: Taylor Simpson --- target/hexagon/iclass.h| 46 target/hexagon/iclass.c| 88 ++ target/hexagon/imported/iclass.def | 52 ++ 3 files