Re: [RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

2024-03-19 Thread Peter Xu
On Tue, Mar 19, 2024 at 07:52:47PM +, Daniel P. Berrangé wrote: > On Tue, Mar 19, 2024 at 03:25:18PM -0400, Peter Xu wrote: > > On Tue, Mar 19, 2024 at 04:25:32PM +, Daniel P. Berrangé wrote: > > > On Fri, Mar 15, 2024 at 04:54:27PM -0400, Peter Xu wrote: > > > > On Fri, Mar 15, 2024 at

Re: [RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

2024-03-19 Thread Daniel P . Berrangé
On Tue, Mar 19, 2024 at 03:25:18PM -0400, Peter Xu wrote: > On Tue, Mar 19, 2024 at 04:25:32PM +, Daniel P. Berrangé wrote: > > On Fri, Mar 15, 2024 at 04:54:27PM -0400, Peter Xu wrote: > > > On Fri, Mar 15, 2024 at 03:01:09PM -0300, Fabiano Rosas wrote: > > > > Peter Xu writes: > > > > > >

Re: [RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

2024-03-19 Thread Peter Xu
On Tue, Mar 19, 2024 at 04:25:32PM +, Daniel P. Berrangé wrote: > On Fri, Mar 15, 2024 at 04:54:27PM -0400, Peter Xu wrote: > > On Fri, Mar 15, 2024 at 03:01:09PM -0300, Fabiano Rosas wrote: > > > Peter Xu writes: > > > > > > > [I queued patch 1-2 into -stable, leaving this patch for further

Re: [RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

2024-03-19 Thread Daniel P . Berrangé
On Fri, Mar 15, 2024 at 09:13:52AM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Fri, Mar 15, 2024 at 12:20:40AM -0300, Fabiano Rosas wrote: > >> The fd: URI has supported migration to a file or socket since before > >> QEMU 8.2. In 8.2 we added the file: URI that supported

Re: [RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

2024-03-19 Thread Daniel P . Berrangé
On Fri, Mar 15, 2024 at 04:54:27PM -0400, Peter Xu wrote: > On Fri, Mar 15, 2024 at 03:01:09PM -0300, Fabiano Rosas wrote: > > Peter Xu writes: > > > > > [I queued patch 1-2 into -stable, leaving this patch for further > > > discussions] > > > > > > On Fri, Mar 15, 2024 at 08:55:42AM +,

Re: [RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

2024-03-15 Thread Peter Xu
On Fri, Mar 15, 2024 at 03:01:09PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > [I queued patch 1-2 into -stable, leaving this patch for further > > discussions] > > > > On Fri, Mar 15, 2024 at 08:55:42AM +, Daniel P. Berrangé wrote: > >> The 'file:' protocol eventually calls into

Re: [RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

2024-03-15 Thread Fabiano Rosas
Peter Xu writes: > [I queued patch 1-2 into -stable, leaving this patch for further > discussions] > > On Fri, Mar 15, 2024 at 08:55:42AM +, Daniel P. Berrangé wrote: >> The 'file:' protocol eventually calls into qemu_open, and this >> transparently allows for FD passing using

Re: [RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

2024-03-15 Thread Peter Xu
[I queued patch 1-2 into -stable, leaving this patch for further discussions] On Fri, Mar 15, 2024 at 08:55:42AM +, Daniel P. Berrangé wrote: > The 'file:' protocol eventually calls into qemu_open, and this > transparently allows for FD passing using /dev/fdset/NNN syntax > to pass in FDs.

Re: [RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

2024-03-15 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Fri, Mar 15, 2024 at 12:20:40AM -0300, Fabiano Rosas wrote: >> The fd: URI has supported migration to a file or socket since before >> QEMU 8.2. In 8.2 we added the file: URI that supported migration to a >> file. So now we have two ways (three if you count

Re: [RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

2024-03-15 Thread Daniel P . Berrangé
On Fri, Mar 15, 2024 at 12:20:40AM -0300, Fabiano Rosas wrote: > The fd: URI has supported migration to a file or socket since before > QEMU 8.2. In 8.2 we added the file: URI that supported migration to a > file. So now we have two ways (three if you count exec:>cat) to > migrate to a file. Fine.

[RFC PATCH v3 3/3] migration: Add fd to FileMigrationArgs

2024-03-14 Thread Fabiano Rosas
The fd: URI has supported migration to a file or socket since before QEMU 8.2. In 8.2 we added the file: URI that supported migration to a file. So now we have two ways (three if you count exec:>cat) to migrate to a file. Fine. However, In 8.2 we also added the new qmp_migrate API that uses a