Re: [RFC PATCH v8 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-21 Thread Peter Maydell
On Mon, 18 Mar 2024 at 09:37, Jinjie Ruan wrote: > > This only implements the external delivery method via the GICv3. > > Signed-off-by: Jinjie Ruan > Reviewed-by: Richard Henderson > @@ -692,13 +719,13 @@ static inline bool arm_excp_unmasked(CPUState *cs, > unsigned int excp_idx, >

Re: [RFC PATCH v8 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-21 Thread Peter Maydell
On Thu, 21 Mar 2024 at 09:27, Jinjie Ruan wrote: > > > > On 2024/3/20 1:28, Peter Maydell wrote: > > On Mon, 18 Mar 2024 at 09:37, Jinjie Ruan wrote: > >> > >> This only implements the external delivery method via the GICv3. > >> > >> Signed-off-by: Jinjie Ruan > >> Reviewed-by: Richard

Re: [RFC PATCH v8 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-21 Thread Jinjie Ruan via
On 2024/3/20 1:28, Peter Maydell wrote: > On Mon, 18 Mar 2024 at 09:37, Jinjie Ruan wrote: >> >> This only implements the external delivery method via the GICv3. >> >> Signed-off-by: Jinjie Ruan >> Reviewed-by: Richard Henderson >> --- >> v8: >> - Fix the rcu stall after sending a VNMI in

Re: [RFC PATCH v8 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-20 Thread Jinjie Ruan via
On 2024/3/20 3:26, Peter Maydell wrote: > On Tue, 19 Mar 2024 at 18:51, Richard Henderson > wrote: >> >> On 3/19/24 07:28, Peter Maydell wrote: switch (excp_idx) { +case EXCP_NMI: +pstate_unmasked = !allIntMask; +break; + +case

Re: [RFC PATCH v8 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-19 Thread Peter Maydell
On Tue, 19 Mar 2024 at 18:51, Richard Henderson wrote: > > On 3/19/24 07:28, Peter Maydell wrote: > >> switch (excp_idx) { > >> +case EXCP_NMI: > >> +pstate_unmasked = !allIntMask; > >> +break; > >> + > >> +case EXCP_VNMI: > >> +if ((!(hcr_el2 & HCR_IMO) &&

Re: [RFC PATCH v8 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-19 Thread Richard Henderson
On 3/19/24 07:28, Peter Maydell wrote: switch (excp_idx) { +case EXCP_NMI: +pstate_unmasked = !allIntMask; +break; + +case EXCP_VNMI: +if ((!(hcr_el2 & HCR_IMO) && !(hcr_el2 & HCR_FMO)) || + (hcr_el2 & HCR_TGE)) { +/* VNMIs(VIRQs or

Re: [RFC PATCH v8 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-19 Thread Peter Maydell
On Mon, 18 Mar 2024 at 09:37, Jinjie Ruan wrote: > > This only implements the external delivery method via the GICv3. > > Signed-off-by: Jinjie Ruan > Reviewed-by: Richard Henderson > --- > v8: > - Fix the rcu stall after sending a VNMI in qemu VM. > v7: > - Add Reviewed-by. > v6: > -

[RFC PATCH v8 06/23] target/arm: Add support for Non-maskable Interrupt

2024-03-18 Thread Jinjie Ruan via
This only implements the external delivery method via the GICv3. Signed-off-by: Jinjie Ruan Reviewed-by: Richard Henderson --- v8: - Fix the rcu stall after sending a VNMI in qemu VM. v7: - Add Reviewed-by. v6: - env->cp15.hcr_el2 -> arm_hcr_el2_eff(). - env->cp15.hcrx_el2 ->