Re: [RFC QEMU PATCH v9 1/2] virtio-pci: only reset pm state during resetting

2024-05-10 Thread Chen, Jiqian
On 2024/5/10 18:18, Michael S. Tsirkin wrote: > On Tue, Apr 16, 2024 at 03:01:26PM +0800, Jiqian Chen wrote: >> Fix bug imported by 27ce0f3afc9dd25d21b43bbce505157afd93d111 >> (fix Power Management Control Register for PCI Express virtio devices) > > > should be: > > 27ce0f3afc9dd ("fix Power

Re: [RFC QEMU PATCH v9 1/2] virtio-pci: only reset pm state during resetting

2024-05-10 Thread Michael S. Tsirkin
On Tue, Apr 16, 2024 at 03:01:26PM +0800, Jiqian Chen wrote: > Fix bug imported by 27ce0f3afc9dd25d21b43bbce505157afd93d111 > (fix Power Management Control Register for PCI Express virtio devices) should be: 27ce0f3afc9dd ("fix Power Management Control Register for PCI Express virtio devices"

Re: [RFC QEMU PATCH v9 1/2] virtio-pci: only reset pm state during resetting

2024-05-10 Thread Chen, Jiqian
Hi, On 2024/4/16 15:01, Jiqian Chen wrote: > Fix bug imported by 27ce0f3afc9dd25d21b43bbce505157afd93d111 > (fix Power Management Control Register for PCI Express virtio devices) > > Only state of PM_CTRL is writable. > Only when flag VIRTIO_PCI_FLAG_INIT_PM is set, need to reset state. > >

[RFC QEMU PATCH v9 1/2] virtio-pci: only reset pm state during resetting

2024-04-16 Thread Jiqian Chen
Fix bug imported by 27ce0f3afc9dd25d21b43bbce505157afd93d111 (fix Power Management Control Register for PCI Express virtio devices) Only state of PM_CTRL is writable. Only when flag VIRTIO_PCI_FLAG_INIT_PM is set, need to reset state. Signed-off-by: Jiqian Chen --- hw/virtio/virtio-pci.c | 8