From: Cédric Le Goater <c...@redhat.com> g_path_get_basename() is a portable utility function that has the advantage of not modifing the string argument. It also fixes a compile breakage with the Musl C library reported in [1].
[1] https://lore.kernel.org/all/20231212010228.2701544-1-raj.k...@gmail.com/ Reported-by: Khem Raj <raj.k...@gmail.com> Reviewed-by: Eric Auger <eric.au...@redhat.com> Reviewed-by: Zhao Liu <zhao1....@intel.com> Reviewed-by: Zhenzhong Duan <zhenzhong.d...@intel.com> Signed-off-by: Cédric Le Goater <c...@redhat.com> (cherry picked from commit 213ae3ffda463c0503e39e0cf827511b5298c314) Signed-off-by: Michael Tokarev <m...@tls.msk.ru> diff --git a/hw/vfio/container.c b/hw/vfio/container.c index 242010036a..adc3005beb 100644 --- a/hw/vfio/container.c +++ b/hw/vfio/container.c @@ -848,7 +848,8 @@ static void vfio_put_base_device(VFIODevice *vbasedev) static int vfio_device_groupid(VFIODevice *vbasedev, Error **errp) { - char *tmp, group_path[PATH_MAX], *group_name; + char *tmp, group_path[PATH_MAX]; + g_autofree char *group_name = NULL; int ret, groupid; ssize_t len; @@ -864,7 +865,7 @@ static int vfio_device_groupid(VFIODevice *vbasedev, Error **errp) group_path[len] = 0; - group_name = basename(group_path); + group_name = g_path_get_basename(group_path); if (sscanf(group_name, "%d", &groupid) != 1) { error_setg_errno(errp, errno, "failed to read %s", group_path); return -errno; -- 2.39.2
