Re: About the instance_finalize callback in VFIO PCI

2023-03-22 Thread Yang Zhong
On Wed, Mar 22, 2023 at 12:22:27PM -0600, Alex Williamson wrote: > On Wed, 22 Mar 2023 09:10:20 -0400 > Yang Zhong wrote: > > > On Wed, Mar 22, 2023 at 01:56:13PM +0100, Cédric Le Goater wrote: > > > On 3/22/23 13:28, Yang Zhong wrote: > > > > On Tue, Mar 21, 2023 at 06:30:14PM +0100, Cédric Le

Re: About the instance_finalize callback in VFIO PCI

2023-03-22 Thread Alex Williamson
On Wed, 22 Mar 2023 09:10:20 -0400 Yang Zhong wrote: > On Wed, Mar 22, 2023 at 01:56:13PM +0100, Cédric Le Goater wrote: > > On 3/22/23 13:28, Yang Zhong wrote: > > > On Tue, Mar 21, 2023 at 06:30:14PM +0100, Cédric Le Goater wrote: > > > > On 3/20/23 10:31, Yang Zhong wrote: > > > > > Hell

Re: About the instance_finalize callback in VFIO PCI

2023-03-22 Thread Yang Zhong
On Wed, Mar 22, 2023 at 01:56:13PM +0100, Cédric Le Goater wrote: > On 3/22/23 13:28, Yang Zhong wrote: > > On Tue, Mar 21, 2023 at 06:30:14PM +0100, Cédric Le Goater wrote: > > > On 3/20/23 10:31, Yang Zhong wrote: > > > > Hello Alex and Paolo, > > > > > > > > There is one instance_finalize callb

Re: About the instance_finalize callback in VFIO PCI

2023-03-22 Thread Cédric Le Goater
On 3/22/23 13:28, Yang Zhong wrote: On Tue, Mar 21, 2023 at 06:30:14PM +0100, Cédric Le Goater wrote: On 3/20/23 10:31, Yang Zhong wrote: Hello Alex and Paolo, There is one instance_finalize callback definition in hw/vfio/pci.c, but i find this callback(vfio_instance_finalize()) never be calle

Re: About the instance_finalize callback in VFIO PCI

2023-03-22 Thread Yang Zhong
On Tue, Mar 21, 2023 at 09:44:18PM +0100, Paolo Bonzini wrote: > Il mar 21 mar 2023, 18:30 Cédric Le Goater ha scritto: > > > I would have thought that user_creatable_cleanup would have taken care > > of it. But it's not. This needs some digging. > > > > user_creatable_cleanup is only for -objec

Re: About the instance_finalize callback in VFIO PCI

2023-03-22 Thread Yang Zhong
On Tue, Mar 21, 2023 at 06:30:14PM +0100, Cédric Le Goater wrote: > On 3/20/23 10:31, Yang Zhong wrote: > > Hello Alex and Paolo, > > > > There is one instance_finalize callback definition in hw/vfio/pci.c, but > > i find this callback(vfio_instance_finalize()) never be called during the > > VM sh

Re: About the instance_finalize callback in VFIO PCI

2023-03-21 Thread Paolo Bonzini
Il mar 21 mar 2023, 18:30 Cédric Le Goater ha scritto: > I would have thought that user_creatable_cleanup would have taken care > of it. But it's not. This needs some digging. > user_creatable_cleanup is only for -object, not for -device. Paolo > C. > > > > By the way, i also debugged other i

Re: About the instance_finalize callback in VFIO PCI

2023-03-21 Thread Cédric Le Goater
On 3/20/23 10:31, Yang Zhong wrote: Hello Alex and Paolo, There is one instance_finalize callback definition in hw/vfio/pci.c, but i find this callback(vfio_instance_finalize()) never be called during the VM shutdown with close VM or "init 0" command in guest. The Qemu related command:

About the instance_finalize callback in VFIO PCI

2023-03-20 Thread Yang Zhong
Hello Alex and Paolo, There is one instance_finalize callback definition in hw/vfio/pci.c, but i find this callback(vfio_instance_finalize()) never be called during the VM shutdown with close VM or "init 0" command in guest. The Qemu related command: .. -device vfio-pci,host=d9:00.0