Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Dave Martin
On Mon, Oct 19, 2020 at 05:23:11PM +0200, Andrew Jones wrote: > On Mon, Oct 19, 2020 at 03:58:40PM +0100, Dave Martin wrote: > > On Mon, Oct 19, 2020 at 03:18:11PM +0100, Peter Maydell wrote: > > > On Mon, 19 Oct 2020 at 14:40, Andrew Jones wrote: > > > > > > > > On Mon, Oct 19, 2020 at 12:43:33PM

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Andrew Jones
On Mon, Oct 19, 2020 at 03:58:40PM +0100, Dave Martin wrote: > On Mon, Oct 19, 2020 at 03:18:11PM +0100, Peter Maydell wrote: > > On Mon, 19 Oct 2020 at 14:40, Andrew Jones wrote: > > > > > > On Mon, Oct 19, 2020 at 12:43:33PM +0100, Peter Maydell wrote: > > > > Well, ID regs are special in the ar

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Dave Martin
On Mon, Oct 19, 2020 at 03:18:11PM +0100, Peter Maydell wrote: > On Mon, 19 Oct 2020 at 14:40, Andrew Jones wrote: > > > > On Mon, Oct 19, 2020 at 12:43:33PM +0100, Peter Maydell wrote: > > > Well, ID regs are special in the architecture -- they always exist > > > and must RAZ/WI, even if they're

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Peter Maydell
On Mon, 19 Oct 2020 at 14:40, Andrew Jones wrote: > > On Mon, Oct 19, 2020 at 12:43:33PM +0100, Peter Maydell wrote: > > Well, ID regs are special in the architecture -- they always exist > > and must RAZ/WI, even if they're not actually given any fields yet. > > This is different from other "unus

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Andrew Jones
On Mon, Oct 19, 2020 at 12:43:33PM +0100, Peter Maydell wrote: > On Mon, 19 Oct 2020 at 12:32, Dave Martin wrote: > > I'm not quite sure about Peter's assessment here. > > > > I agree with the inconsistency identified here: we always enumerate all > > unallocated ID regs, but we enumerate ID_AA64Z

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Peter Maydell
On Mon, 19 Oct 2020 at 12:32, Dave Martin wrote: > I'm not quite sure about Peter's assessment here. > > I agree with the inconsistency identified here: we always enumerate all > unallocated ID regs, but we enumerate ID_AA64ZFR0_EL1 conditionally. > This doesn't feel right: on a non-SVE guest, ID_

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Dave Martin
On Mon, Oct 19, 2020 at 11:25:25AM +0200, Andrew Jones wrote: > On Thu, Oct 15, 2020 at 03:57:02PM +0100, Peter Maydell wrote: > > On Thu, 15 Oct 2020 at 15:41, Andrew Jones wrote: > > > The reporter states neither the source nor destination hardware supports > > > SVE. My guess is that what's hap

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Andrew Jones
On Thu, Oct 15, 2020 at 03:57:02PM +0100, Peter Maydell wrote: > On Thu, 15 Oct 2020 at 15:41, Andrew Jones wrote: > > The reporter states neither the source nor destination hardware supports > > SVE. My guess is that what's happening is the reserved ID register > > ID_UNALLOCATED(4,4) was showing

Re: Kernel patch cases qemu live migration failed.

2020-10-15 Thread Peter Maydell
On Thu, 15 Oct 2020 at 15:41, Andrew Jones wrote: > The reporter states neither the source nor destination hardware supports > SVE. My guess is that what's happening is the reserved ID register > ID_UNALLOCATED(4,4) was showing up in the KVM_GET_REG_LIST count on > the old kernel, but the new kern

Re: Kernel patch cases qemu live migration failed.

2020-10-15 Thread Andrew Jones
On Thu, Oct 15, 2020 at 02:52:34PM +0100, Marc Zyngier wrote: > On 2020-10-15 14:35, Andrew Jones wrote: > > On Thu, Oct 15, 2020 at 12:26:10PM +0100, Marc Zyngier wrote: > > > Hi > > > > > > Please don't use my arm.com address anymore, nobody reads it... > > > > > > On 2020-10-15 05:06, 张东旭 wrot

Re: Kernel patch cases qemu live migration failed.

2020-10-15 Thread Marc Zyngier
On 2020-10-15 14:35, Andrew Jones wrote: On Thu, Oct 15, 2020 at 12:26:10PM +0100, Marc Zyngier wrote: Hi Please don't use my arm.com address anymore, nobody reads it... On 2020-10-15 05:06, 张东旭 wrote: > I'm so sorry for disturbing you. > > When I apply this kernel patch:KVM: arm64/sve: System

Re: Kernel patch cases qemu live migration failed.

2020-10-15 Thread Andrew Jones
On Thu, Oct 15, 2020 at 12:26:10PM +0100, Marc Zyngier wrote: > Hi > > Please don't use my arm.com address anymore, nobody reads it... > > On 2020-10-15 05:06, 张东旭 wrote: > > I'm so sorry for disturbing you. > > > > When I apply this kernel patch:KVM: arm64/sve: System register > > context switc

Re: Kernel patch cases qemu live migration failed.

2020-10-15 Thread Andrew Jones
On Thu, Oct 15, 2020 at 12:06:39PM +0800, 张东旭 wrote: > I'm so sorry for disturbing you.When I apply this kernel patch:KVM: > arm64/sve: System register context switch and access > supporthttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64/kvm/sys_regs.c?id=7343376

Kernel patch cases qemu live migration failed.

2020-10-15 Thread 张东旭
I'm so sorry for disturbing you.When I apply this kernel patch:KVM: arm64/sve: System register context switch and access supporthttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64/kvm/sys_regs.c?id=73433762fcaeb9d59e84d299021c6b15466c96ddqemu live migration will

Re: Kernel patch cases qemu live migration failed.

2020-10-15 Thread Marc Zyngier
Hi Please don't use my arm.com address anymore, nobody reads it... On 2020-10-15 05:06, 张东旭 wrote: I'm so sorry for disturbing you. When I apply this kernel patch:KVM: arm64/sve: System register context switch and access support https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi