RE: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-28 Thread Liu, Yi L
> From: Peter Xu > Sent: Monday, November 29, 2021 11:14 AM > > On Mon, Nov 29, 2021 at 10:28:42AM +0800, Jason Wang wrote: > > > > And in the future, it could be even more troublesome,e.g there's one > > day we found another bit that needs not to be checked. Maybe we should > > even remove all t

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-28 Thread Jason Wang
On Mon, Nov 29, 2021 at 11:14 AM Peter Xu wrote: > > On Mon, Nov 29, 2021 at 10:28:42AM +0800, Jason Wang wrote: > > > I think we can still have Jason's patch continued because the kernel > > > commit to > > > apply SNP bit is merged in v5.13, so we may need the qemu change to let it > > > still

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-28 Thread Peter Xu
On Mon, Nov 29, 2021 at 10:28:42AM +0800, Jason Wang wrote: > > I think we can still have Jason's patch continued because the kernel commit > > to > > apply SNP bit is merged in v5.13, so we may need the qemu change to let it > > still work with v5.13-v5.15+ guest kernels. We'll loose the resv bi

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-28 Thread Jason Wang
On Mon, Nov 29, 2021 at 9:19 AM Peter Xu wrote: > > On Sun, Nov 28, 2021 at 07:06:18AM +, Liu, Yi L wrote: > > > From: Peter Xu > > > Sent: Thursday, November 25, 2021 2:14 PM > > > > > > On Thu, Nov 25, 2021 at 05:49:38AM +, Liu, Yi L wrote: > > > > > From: Peter Xu > > > > > Sent: Thur

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-28 Thread Peter Xu
On Sun, Nov 28, 2021 at 07:06:18AM +, Liu, Yi L wrote: > > From: Peter Xu > > Sent: Thursday, November 25, 2021 2:14 PM > > > > On Thu, Nov 25, 2021 at 05:49:38AM +, Liu, Yi L wrote: > > > > From: Peter Xu > > > > Sent: Thursday, November 25, 2021 12:31 PM > > > > > > > > On Thu, Nov 25,

RE: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-27 Thread Liu, Yi L
> From: Peter Xu > Sent: Thursday, November 25, 2021 2:14 PM > > On Thu, Nov 25, 2021 at 05:49:38AM +, Liu, Yi L wrote: > > > From: Peter Xu > > > Sent: Thursday, November 25, 2021 12:31 PM > > > > > > On Thu, Nov 25, 2021 at 04:03:34AM +, Liu, Yi L wrote: > > > > > From: Peter Xu > > >

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Peter Xu
On Thu, Nov 25, 2021 at 05:49:38AM +, Liu, Yi L wrote: > > From: Peter Xu > > Sent: Thursday, November 25, 2021 12:31 PM > > > > On Thu, Nov 25, 2021 at 04:03:34AM +, Liu, Yi L wrote: > > > > From: Peter Xu > > > > Sent: Wednesday, November 24, 2021 3:57 PM > > > > > > > > On Wed, Nov 24

RE: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Liu, Yi L
> From: Jason Wang > Sent: Wednesday, November 24, 2021 4:29 PM > > On Wed, Nov 24, 2021 at 3:57 PM Peter Xu wrote: > > > > On Wed, Nov 24, 2021 at 02:03:09PM +0800, Jason Wang wrote: > > > When booting with scalable mode, I hit this error: > > > > > > qemu-system-x86_64: vtd_iova_to_slpte: dete

RE: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Liu, Yi L
> From: Jason Wang > Sent: Wednesday, November 24, 2021 5:35 PM > > On Wed, Nov 24, 2021 at 5:23 PM Peter Xu wrote: > > > > On Wed, Nov 24, 2021 at 05:01:42PM +0800, Jason Wang wrote: > > > > > > > -static bool vtd_slpte_nonzero_rsvd(uint64_t slpte, uint32_t > level) > > > > > > > +static bool v

RE: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Liu, Yi L
> From: Peter Xu > Sent: Thursday, November 25, 2021 12:31 PM > > On Thu, Nov 25, 2021 at 04:03:34AM +, Liu, Yi L wrote: > > > From: Peter Xu > > > Sent: Wednesday, November 24, 2021 3:57 PM > > > > > > On Wed, Nov 24, 2021 at 02:03:09PM +0800, Jason Wang wrote: > > > > When booting with sca

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Peter Xu
On Thu, Nov 25, 2021 at 04:03:34AM +, Liu, Yi L wrote: > > From: Peter Xu > > Sent: Wednesday, November 24, 2021 3:57 PM > > > > On Wed, Nov 24, 2021 at 02:03:09PM +0800, Jason Wang wrote: > > > When booting with scalable mode, I hit this error: > > > > > > qemu-system-x86_64: vtd_iova_to_slp

RE: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Liu, Yi L
> From: Peter Xu > Sent: Wednesday, November 24, 2021 3:57 PM > > On Wed, Nov 24, 2021 at 02:03:09PM +0800, Jason Wang wrote: > > When booting with scalable mode, I hit this error: > > > > qemu-system-x86_64: vtd_iova_to_slpte: detected splte reserve non- > zero iova=0xf002, level=0x1slpte=0x

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Jason Wang
On Wed, Nov 24, 2021 at 6:10 PM Peter Xu wrote: > > On Wed, Nov 24, 2021 at 05:35:18PM +0800, Jason Wang wrote: > > On Wed, Nov 24, 2021 at 5:23 PM Peter Xu wrote: > > > > > > On Wed, Nov 24, 2021 at 05:01:42PM +0800, Jason Wang wrote: > > > > > > > > -static bool vtd_slpte_nonzero_rsvd(uint64_t

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Peter Xu
On Wed, Nov 24, 2021 at 05:35:18PM +0800, Jason Wang wrote: > On Wed, Nov 24, 2021 at 5:23 PM Peter Xu wrote: > > > > On Wed, Nov 24, 2021 at 05:01:42PM +0800, Jason Wang wrote: > > > > > > > -static bool vtd_slpte_nonzero_rsvd(uint64_t slpte, uint32_t > > > > > > > level) > > > > > > > +static b

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Jason Wang
On Wed, Nov 24, 2021 at 5:23 PM Peter Xu wrote: > > On Wed, Nov 24, 2021 at 05:01:42PM +0800, Jason Wang wrote: > > > > > > -static bool vtd_slpte_nonzero_rsvd(uint64_t slpte, uint32_t level) > > > > > > +static bool vtd_slpte_nonzero_rsvd(IntelIOMMUState *s, > > > > > > +

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Peter Xu
On Wed, Nov 24, 2021 at 05:01:42PM +0800, Jason Wang wrote: > > > > > -static bool vtd_slpte_nonzero_rsvd(uint64_t slpte, uint32_t level) > > > > > +static bool vtd_slpte_nonzero_rsvd(IntelIOMMUState *s, > > > > > + uint64_t slpte, uint32_t level) > > > > > { > >

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Jason Wang
On Wed, Nov 24, 2021 at 4:52 PM Peter Xu wrote: > > On Wed, Nov 24, 2021 at 04:28:52PM +0800, Jason Wang wrote: > > On Wed, Nov 24, 2021 at 3:57 PM Peter Xu wrote: > > > > > > On Wed, Nov 24, 2021 at 02:03:09PM +0800, Jason Wang wrote: > > > > When booting with scalable mode, I hit this error: >

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Peter Xu
On Wed, Nov 24, 2021 at 04:28:52PM +0800, Jason Wang wrote: > On Wed, Nov 24, 2021 at 3:57 PM Peter Xu wrote: > > > > On Wed, Nov 24, 2021 at 02:03:09PM +0800, Jason Wang wrote: > > > When booting with scalable mode, I hit this error: > > > > > > qemu-system-x86_64: vtd_iova_to_slpte: detected spl

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Jason Wang
On Wed, Nov 24, 2021 at 3:57 PM Peter Xu wrote: > > On Wed, Nov 24, 2021 at 02:03:09PM +0800, Jason Wang wrote: > > When booting with scalable mode, I hit this error: > > > > qemu-system-x86_64: vtd_iova_to_slpte: detected splte reserve non-zero > > iova=0xf002, level=0x1slpte=0x102681803) >

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Peter Xu
On Wed, Nov 24, 2021 at 02:03:09PM +0800, Jason Wang wrote: > When booting with scalable mode, I hit this error: > > qemu-system-x86_64: vtd_iova_to_slpte: detected splte reserve non-zero > iova=0xf002, level=0x1slpte=0x102681803) > qemu-system-x86_64: vtd_iommu_translate: detected translatio