Re: [PATCH] vfio/pci: Remove vfio_detach_device from vfio_realize error path

2023-10-12 Thread Cédric Le Goater
On 10/11/23 22:09, Eric Auger wrote: In vfio_realize, on the error path, we currently call vfio_detach_device() after a successful vfio_attach_device. While this looks natural, vfio_instance_finalize also induces a vfio_detach_device(), and it seems to be the right place instead as other

Re: [PATCH] vfio/pci: Remove vfio_detach_device from vfio_realize error path

2023-10-12 Thread Eric Auger
Hi Zhenzhong, On 10/12/23 04:34, Duan, Zhenzhong wrote: > >> -Original Message- >> From: Eric Auger >> Sent: Thursday, October 12, 2023 4:10 AM >> To: eric.auger@gmail.com; eric.au...@redhat.com; qemu- >> de...@nongnu.org; alex.william...@redhat.com; c...@redhat.com; Duan, >>

RE: [PATCH] vfio/pci: Remove vfio_detach_device from vfio_realize error path

2023-10-11 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Sent: Thursday, October 12, 2023 4:10 AM >To: eric.auger@gmail.com; eric.au...@redhat.com; qemu- >de...@nongnu.org; alex.william...@redhat.com; c...@redhat.com; Duan, >Zhenzhong ; Liu, Yi L ; >yangh...@redhat.com >Subject: [PATCH] vfio/pci: