On 9/21/23 12:22, Duan, Zhenzhong wrote:
-Original Message-
From: Cédric Le Goater
Sent: Thursday, September 21, 2023 4:42 PM
Subject: Re: [PATCH v1 05/22] vfio/common: Extract out
vfio_kvm_device_[add/del]_fd
On 9/20/23 13:49, Eric Auger wrote:
Hi Zhenzhong,
On 8/30/23 12:37
>-Original Message-
>From: Cédric Le Goater
>Sent: Thursday, September 21, 2023 4:42 PM
>Subject: Re: [PATCH v1 05/22] vfio/common: Extract out
>vfio_kvm_device_[add/del]_fd
>
>On 9/20/23 13:49, Eric Auger wrote:
>> Hi Zhenzhong,
>>
>>
On 9/20/23 13:49, Eric Auger wrote:
Hi Zhenzhong,
On 8/30/23 12:37, Zhenzhong Duan wrote:
...which will be used by both legacy and iommufd backend.
I prefer genuine sentences in the commit msg. Also you explain what you
do but not why.
suggestion: Introduce two new helpers,
>-Original Message-
>From: Alex Williamson
>Sent: Thursday, September 21, 2023 5:40 AM
>Subject: Re: [PATCH v1 05/22] vfio/common: Extract out
>vfio_kvm_device_[add/del]_fd
>
>On Wed, 30 Aug 2023 18:37:37 +0800
>Zhenzhong Duan wrote:
>
>> ...
>-Original Message-
>From: Eric Auger
>Sent: Wednesday, September 20, 2023 7:49 PM
>Subject: Re: [PATCH v1 05/22] vfio/common: Extract out
>vfio_kvm_device_[add/del]_fd
>
>Hi Zhenzhong,
>
>On 8/30/23 12:37, Zhenzhong Duan wrote:
>> ...which will b
On Wed, 30 Aug 2023 18:37:37 +0800
Zhenzhong Duan wrote:
> ...which will be used by both legacy and iommufd backend.
+1 to Eric's comments regarding complete sentences in the commit log
and suggested description.
>
> Signed-off-by: Yi Liu
> Signed-off-by: Zhenzhong Duan
> ---
>
Hi Zhenzhong,
On 8/30/23 12:37, Zhenzhong Duan wrote:
> ...which will be used by both legacy and iommufd backend.
I prefer genuine sentences in the commit msg. Also you explain what you
do but not why.
suggestion: Introduce two new helpers, vfio_kvm_device_[add/del]_fd
which take as input a file
