RE: [PATCH v1 17/22] util/char_dev: Add open_cdev()

2023-09-20 Thread Duan, Zhenzhong
>-Original Message- >From: Daniel P. Berrangé >Sent: Wednesday, September 20, 2023 8:39 PM >Subject: Re: [PATCH v1 17/22] util/char_dev: Add open_cdev() > >On Wed, Aug 30, 2023 at 06:37:49PM +0800, Zhenzhong Duan wrote: >> From: Yi Liu >> >> /

Re: [PATCH v1 17/22] util/char_dev: Add open_cdev()

2023-09-20 Thread Daniel P . Berrangé
On Wed, Sep 20, 2023 at 09:53:46AM -0300, Jason Gunthorpe wrote: > On Wed, Sep 20, 2023 at 01:39:02PM +0100, Daniel P. Berrangé wrote: > > > > diff --git a/util/chardev_open.c b/util/chardev_open.c > > > new file mode 100644 > > > index 00..d03e415131 > > > --- /dev/null > > > +++

Re: [PATCH v1 17/22] util/char_dev: Add open_cdev()

2023-09-20 Thread Jason Gunthorpe
On Wed, Sep 20, 2023 at 01:39:02PM +0100, Daniel P. Berrangé wrote: > > diff --git a/util/chardev_open.c b/util/chardev_open.c > > new file mode 100644 > > index 00..d03e415131 > > --- /dev/null > > +++ b/util/chardev_open.c > > @@ -0,0 +1,61 @@ > > +/* > > + * Copyright (C) 2023 Intel

Re: [PATCH v1 17/22] util/char_dev: Add open_cdev()

2023-09-20 Thread Daniel P . Berrangé
On Wed, Aug 30, 2023 at 06:37:49PM +0800, Zhenzhong Duan wrote: > From: Yi Liu > > /dev/vfio/devices/vfioX may not exist. In that case it is still possible > to open /dev/char/$major:$minor instead. Add helper function to abstract > the cdev open. > > Suggested-by: Jason Gunthorpe >