Re: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-09 Thread Juan Quintela
Vladimir Sementsov-Ogievskiy wrote: > COLO is not listed as running state in migrate_is_running(), so, it's > theoretically possible to disable colo capability in COLO state and the > unexpected error in migration_iteration_finish() is reachable. > > Let's disallow that in

Re: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-09 Thread Juan Quintela
"Zhang, Chen" wrote: >> -Original Message- >> From: Vladimir Sementsov-Ogievskiy >> Sent: Thursday, May 4, 2023 4:23 PM >> To: Zhang, Chen ; qemu-devel@nongnu.org >> Cc: lukasstra...@web.de; quint...@redhat.com; Peter Xu >> ; Leonardo Br

RE: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Thursday, May 4, 2023 4:23 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Peter Xu > ; Leonardo Bras > Subject: Re: [PATCH v4 09/10] migration: disallo

Re: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-04 Thread Vladimir Sementsov-Ogievskiy
On 04.05.23 11:09, Zhang, Chen wrote: -Original Message- From: Vladimir Sementsov-Ogievskiy Sent: Saturday, April 29, 2023 3:49 AM To: qemu-devel@nongnu.org Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen ; vsement...@yandex-team.ru; Peter Xu ; Leonardo Bras Subject:

RE: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Peter Xu > ; Leonardo Bras > Subject: [PATCH v4 09/10] migration:

Re: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-02 Thread Peter Xu
On Fri, Apr 28, 2023 at 10:49:27PM +0300, Vladimir Sementsov-Ogievskiy wrote: > COLO is not listed as running state in migrate_is_running(), so, it's > theoretically possible to disable colo capability in COLO state and the > unexpected error in migration_iteration_finish() is reachable. > >