RE: [PATCH v5] introduce vfio-user protocol specification

2020-11-09 Thread Thanos Makatos
hangpeng@intel.com; > dgilb...@redhat.com > Subject: Re: [PATCH v5] introduce vfio-user protocol specification > > On Thu, Nov 05, 2020 at 05:50:27PM -0800, John G Johnson wrote: > > > The idea behind the version IDs is to identify incompatible protocol > > cha

RE: [PATCH v5] introduce vfio-user protocol specification

2020-11-09 Thread Thanos Makatos
> > > * *Error* in a reply message indicates the command being > acknowledged > > had > > > an error. In this case, the *Error* field will be valid. > > > > > > * *Error* in a reply message is a UNIX errno value. It is reserved in a > > command message. > > > > I'm not quite following why we

Re: [PATCH v5] introduce vfio-user protocol specification

2020-11-07 Thread John Levon
On Thu, Nov 05, 2020 at 05:50:27PM -0800, John G Johnson wrote: > The idea behind the version IDs is to identify incompatible protocol > changes as major versions, and compatible changes as minor versions. What > would be the purpose of the third version type? Well, like any patch

Re: [PATCH v5] introduce vfio-user protocol specification

2020-11-05 Thread John G Johnson
.com; Marc-André Lureau >> ; ism...@linux.com; >> alex.william...@redhat.com; Stefan Hajnoczi ; >> Felipe Franciosi ; xiuchun...@intel.com; >> tomassetti.and...@gmail.com; changpeng....@intel.com; Raphael Norwitz >> ; kanth.ghatr...@oracle.com >> Subject: Re: [PA

RE: [PATCH v5] introduce vfio-user protocol specification

2020-11-02 Thread Thanos Makatos
iosi ; xiuchun...@intel.com; > tomassetti.and...@gmail.com; changpeng@intel.com; Raphael Norwitz > ; kanth.ghatr...@oracle.com > Subject: Re: [PATCH v5] introduce vfio-user protocol specification > > On

Re: [PATCH v5] introduce vfio-user protocol specification

2020-11-02 Thread John Levon
On Mon, Nov 02, 2020 at 11:29:23AM +, Thanos Makatos wrote: > > +==++= > > ==+ > > > | version | object | ``{"major": , "minor": }`` > > > | > > > | ||

RE: [PATCH v5] introduce vfio-user protocol specification

2020-11-02 Thread Thanos Makatos
u > ; tina.zh...@intel.com; > changpeng@intel.com > Subject: Re: [PATCH v5] introduce vfio-user protocol specification > > On Wed, Oct 28, 2020 at 04:41:31PM +, Thanos Makatos wrote: > > > FYI here's v5 of the vfio-user protocol, my --cc in git send-email got > > messed

Re: [PATCH v5] introduce vfio-user protocol specification

2020-10-30 Thread John Levon
On Wed, Oct 28, 2020 at 04:41:31PM +, Thanos Makatos wrote: > FYI here's v5 of the vfio-user protocol, my --cc in git send-email got messed > up somehow Hi Thanos, this looks great, I just had some minor questions below. > Command Concurrency > --- > A client may pipeline

RE: [PATCH v5] introduce vfio-user protocol specification

2020-10-28 Thread Thanos Makatos
FYI here's v5 of the vfio-user protocol, my --cc in git send-email got messed up somehow > -Original Message- > From: Qemu-devel bounces+thanos.makatos=nutanix@nongnu.org> On Behalf Of Thanos > Makatos > Sent: 28 October 2020 16:10 > To: qemu-devel@nongnu.org > Subject: [PATCH v5]