RE: [RFC PATCH v3 09/34] Hexagon (target/hexagon) architecture types

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 8:19 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PA

Re: [RFC PATCH v3 09/34] Hexagon (target/hexagon) architecture types

2020-08-26 Thread Richard Henderson
On 8/18/20 8:50 AM, Taylor Simpson wrote: > +#ifndef HEXAGON_ARCH_TYPES_H > +#define HEXAGON_ARCH_TYPES_H > + > +#include Do you really need to re-include this? This was done in "qemu/osdep.h". In general, osdep.h must be included first, and it takes care of all of the basic system includes.