Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

On 9/24/20 10:18 AM, Taylor Simpson wrote: >> You've got a script generating stuff. It can just as easily generate two >> different lists. You're trying to do too much with the C preprocessor and >> too >> little with python. > > Sure, generating two lists was also suggested by Alessandro

RE: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

> -Original Message- > From: Richard Henderson > Sent: Thursday, September 24, 2020 9:04 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PA

Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

M >>>>> To: Taylor Simpson ; qemu-devel@nongnu.org >>>>> Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; >>>>> aleksandar.m.m...@gmail.com; a...@rev.ng >>>>> Subject: Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for &

RE: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

.org > > >> Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > > >> aleksandar.m.m...@gmail.com; a...@rev.ng > > >> Subject: Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for > > >> instructions with multiple definitions > > >

RE: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

>> To: Taylor Simpson ; qemu-devel@nongnu.org > >> Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > >> aleksandar.m.m...@gmail.com; a...@rev.ng > >> Subject: Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for > >> instruc

Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

i.fi; >> aleksandar.m.m...@gmail.com; a...@rev.ng >> Subject: Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for >> instructions with multiple definitions >> >> The fGEN_TCG_A2_add macro does not require nor use that {...} argument. > > The fGEN_TCG_A2_add macro

RE: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

> -Original Message- > From: Richard Henderson > Sent: Monday, August 31, 2020 1:20 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PA

Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

On 8/31/20 11:14 AM, Taylor Simpson wrote: > Just to be explicit, the code that generates code is generated as > #ifdef fGEN_TCG_A2_add > fGEN_TCG_A2_add({ RdV=RsV+RtV;}); > #else > do { > gen_helper_A2_add(RdV, cpu_env, RsV, RtV); > } while (0); > #endif > If we're

RE: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

> -Original Message- > From: Richard Henderson > Sent: Monday, August 31, 2020 11:29 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PA

Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

On 8/31/20 10:08 AM, Taylor Simpson wrote: > There are some assumptions here I'd like to clarify. When I started this > discussion, there seemed to be general resistance to the concept of a > generator. Because of this, I made the generator as simple as possible and > pushed the complexity and

RE: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

gmail.com; a...@rev.ng > >> Subject: Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for > >> instructions with multiple definitions > >> > >> On 8/30/20 12:48 PM, Taylor Simpson wrote: > >>> I'll add the following comment to indicate what's

Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

i.fi; >> aleksandar.m.m...@gmail.com; a...@rev.ng >> Subject: Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for >> instructions with multiple definitions >> >> On 8/30/20 12:48 PM, Taylor Simpson wrote: >>> I'll add the following comment to indicate what's going

RE: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

> -Original Message- > From: Richard Henderson > Sent: Sunday, August 30, 2020 3:13 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PA

Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

On 8/30/20 12:48 PM, Taylor Simpson wrote: > I'll add the following comment to indicate what's going on > > /* > * Each of the generated helpers is wrapped with #ifndef fGEN_TCG_. > * For example >* #ifndef fGEN_TCG_A2_add >* DEF_HELPER_3(A2_add, s32, env, s32, s32) >*

RE: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

> -Original Message- > From: Richard Henderson > Sent: Friday, August 28, 2020 8:03 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PA

Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for instructions with multiple definitions

On 8/18/20 8:50 AM, Taylor Simpson wrote: > +++ b/target/hexagon/helper.h > @@ -15,6 +15,8 @@ > * along with this program; if not, see . > */ > > +#include "gen_tcg.h" Why would you need this here? Definitely looks wrong. r~