Re: RFC: towards systemd socket activation in q-s-d

2023-01-31 Thread Daniel P . Berrangé
On Tue, Jan 31, 2023 at 12:17:07PM +0100, Kevin Wolf wrote: > Am 30.01.2023 um 15:58 hat Daniel P. Berrangé geschrieben: > > > I'm at a point where I can take a shot at implementing this, but want > > > some feedback on whether it is better to try to shoehorn a generic > > > solution into the

Re: RFC: towards systemd socket activation in q-s-d

2023-01-31 Thread Kevin Wolf
Am 30.01.2023 um 15:58 hat Daniel P. Berrangé geschrieben: > > I'm at a point where I can take a shot at implementing this, but want > > some feedback on whether it is better to try to shoehorn a generic > > solution into the existing @fd member of the SocketAddressType union, > > or whether it

Re: RFC: towards systemd socket activation in q-s-d

2023-01-30 Thread Richard W.M. Jones
On Mon, Jan 30, 2023 at 04:45:08PM +, Daniel P. Berrangé wrote: > which is LISTEN_FDS=2, LISTEN_FDNAMES=control,vnc Colon for separating the elements not comma. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization

Re: RFC: towards systemd socket activation in q-s-d

2023-01-30 Thread Daniel P . Berrangé
On Mon, Jan 30, 2023 at 02:58:01PM +, Daniel P. Berrangé wrote: > > I'm at a point where I can take a shot at implementing this, but want > > some feedback on whether it is better to try to shoehorn a generic > > solution into the existing @fd member of the SocketAddressType union, > > or

Re: RFC: towards systemd socket activation in q-s-d

2023-01-30 Thread Daniel P . Berrangé
On Mon, Jan 30, 2023 at 03:44:48PM +, Richard W.M. Jones wrote: > On Mon, Jan 30, 2023 at 02:58:01PM +, Daniel P. Berrangé wrote: > > Obviously at startup QEMU can trivially inherit the FDs from whatever > > spawned it. The only task is to identify the FDs that are passed into, > > and

Re: RFC: towards systemd socket activation in q-s-d

2023-01-30 Thread Richard W.M. Jones
On Mon, Jan 30, 2023 at 02:58:01PM +, Daniel P. Berrangé wrote: > Obviously at startup QEMU can trivially inherit the FDs from whatever > spawned it. The only task is to identify the FDs that are passed into, > and systemd defined a mechanism for this using LISTEN_FDNAMES. IOW the > socket

Re: RFC: towards systemd socket activation in q-s-d

2023-01-30 Thread Daniel P . Berrangé
On Fri, Jan 27, 2023 at 03:26:15PM -0600, Eric Blake wrote: > In https://bugzilla.redhat.com/show_bug.cgi?id=2055229, the question > was raised on how to make qemu-storage-daemon sufficiently powerful to > be a full-blown replacement to qemu-nbd. One of the features still > lacking is the ability

Re: RFC: towards systemd socket activation in q-s-d

2023-01-27 Thread Richard W.M. Jones
On Fri, Jan 27, 2023 at 03:26:15PM -0600, Eric Blake wrote: > In https://bugzilla.redhat.com/show_bug.cgi?id=2055229, the question > was raised on how to make qemu-storage-daemon sufficiently powerful to > be a full-blown replacement to qemu-nbd. One of the features still > lacking is the ability

RFC: towards systemd socket activation in q-s-d

2023-01-27 Thread Eric Blake
In https://bugzilla.redhat.com/show_bug.cgi?id=2055229, the question was raised on how to make qemu-storage-daemon sufficiently powerful to be a full-blown replacement to qemu-nbd. One of the features still lacking is the ability to do systemd socket activation (qemu-nbd does this,