Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-03-01 Thread Gavin Shan
Hi Igor, On 2/28/22 6:54 PM, Igor Mammedov wrote: On Mon, 28 Feb 2022 12:26:53 +0800 Gavin Shan wrote: On 2/25/22 6:03 PM, Igor Mammedov wrote: On Fri, 25 Feb 2022 16:41:43 +0800 Gavin Shan wrote: On 2/17/22 10:14 AM, Gavin Shan wrote: On 1/26/22 5:14 PM, Igor Mammedov wrote: On Wed, 26 J

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-02-28 Thread Igor Mammedov
On Mon, 28 Feb 2022 12:26:53 +0800 Gavin Shan wrote: > Hi Igor, > > On 2/25/22 6:03 PM, Igor Mammedov wrote: > > On Fri, 25 Feb 2022 16:41:43 +0800 > > Gavin Shan wrote: > >> On 2/17/22 10:14 AM, Gavin Shan wrote: > >>> On 1/26/22 5:14 PM, Igor Mammedov wrote: > On Wed, 26 Jan 2022 1

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-02-27 Thread Gavin Shan
Hi Igor, On 2/25/22 6:03 PM, Igor Mammedov wrote: On Fri, 25 Feb 2022 16:41:43 +0800 Gavin Shan wrote: On 2/17/22 10:14 AM, Gavin Shan wrote: On 1/26/22 5:14 PM, Igor Mammedov wrote: On Wed, 26 Jan 2022 13:24:10 +0800 Gavin Shan wrote: The default CPU-to-NUMA association is given by mc-

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-02-25 Thread Igor Mammedov
On Fri, 25 Feb 2022 16:41:43 +0800 Gavin Shan wrote: > Hi Igor, > > On 2/17/22 10:14 AM, Gavin Shan wrote: > > On 1/26/22 5:14 PM, Igor Mammedov wrote: > >> On Wed, 26 Jan 2022 13:24:10 +0800 > >> Gavin Shan wrote: > >> > >>> The default CPU-to-NUMA association is given by > >>> mc->get_de

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-02-25 Thread Gavin Shan
Hi Igor, On 2/17/22 10:14 AM, Gavin Shan wrote: On 1/26/22 5:14 PM, Igor Mammedov wrote: On Wed, 26 Jan 2022 13:24:10 +0800 Gavin Shan wrote: The default CPU-to-NUMA association is given by mc->get_default_cpu_node_id() when it isn't provided explicitly. However, the CPU topology isn't fully

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-02-16 Thread Gavin Shan
On 1/26/22 5:14 PM, Igor Mammedov wrote: On Wed, 26 Jan 2022 13:24:10 +0800 Gavin Shan wrote: The default CPU-to-NUMA association is given by mc->get_default_cpu_node_id() when it isn't provided explicitly. However, the CPU topology isn't fully considered in the default association and it caus

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-02-16 Thread Gavin Shan
On 2/15/22 4:32 PM, Andrew Jones wrote: On Tue, Feb 15, 2022 at 04:19:01PM +0800, Gavin Shan wrote: The issue isn't related to CPU topology directly. It's actually related to the fact: the default NUMA node ID will be picked for one particular CPU if the associated NUMA node ID isn't provided by

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-02-15 Thread Gavin Shan
On 1/28/22 3:05 PM, wangyanan (Y) via wrote On 2022/1/26 17:14, Igor Mammedov wrote: On Wed, 26 Jan 2022 13:24:10 +0800 Gavin Shan wrote: The default CPU-to-NUMA association is given by mc->get_default_cpu_node_id() when it isn't provided explicitly. However, the CPU topology isn't fully cons

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-02-15 Thread Andrew Jones
On Tue, Feb 15, 2022 at 04:19:01PM +0800, Gavin Shan wrote: > The issue isn't related to CPU topology directly. It's actually related > to the fact: the default NUMA node ID will be picked for one particular > CPU if the associated NUMA node ID isn't provided by users explicitly. > So it's related

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-02-08 Thread Peter Maydell
On Wed, 26 Jan 2022 at 09:14, Igor Mammedov wrote: > > On Wed, 26 Jan 2022 13:24:10 +0800 > Gavin Shan wrote: > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > > index 141350bf21..b4a95522d3 100644 > > --- a/hw/arm/virt.c > > +++ b/hw/arm/virt.c > > @@ -2499,7 +2499,7 @@ virt_cpu_index_to_props(Ma

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-01-27 Thread wangyanan (Y)
Hi, On 2022/1/26 17:14, Igor Mammedov wrote: On Wed, 26 Jan 2022 13:24:10 +0800 Gavin Shan wrote: The default CPU-to-NUMA association is given by mc->get_default_cpu_node_id() when it isn't provided explicitly. However, the CPU topology isn't fully considered in the default association and it

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-01-26 Thread Igor Mammedov
On Wed, 26 Jan 2022 13:24:10 +0800 Gavin Shan wrote: > The default CPU-to-NUMA association is given by mc->get_default_cpu_node_id() > when it isn't provided explicitly. However, the CPU topology isn't fully > considered in the default association and it causes CPU topology broken > warnings on b

Re: [PATCH] hw/arm/virt: Fix CPU's default NUMA node ID

2022-01-25 Thread Andrew Jones
CCing Igor. Thanks, drew On Wed, Jan 26, 2022 at 01:24:10PM +0800, Gavin Shan wrote: > The default CPU-to-NUMA association is given by mc->get_default_cpu_node_id() > when it isn't provided explicitly. However, the CPU topology isn't fully > considered in the default association and it causes C