Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-28 Thread Yong Huang
On Wed, Feb 28, 2024 at 7:58 PM Kevin Wolf wrote: > Am 28.02.2024 um 12:30 hat Daniel P. Berrangé geschrieben: > > On Wed, Feb 28, 2024 at 11:17:37AM +0100, Kevin Wolf wrote: > > > Until now, @size has been mandatory for creating images with every > > > driver. Maybe we should even have put it

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-28 Thread Kevin Wolf
Am 28.02.2024 um 12:30 hat Daniel P. Berrangé geschrieben: > On Wed, Feb 28, 2024 at 11:17:37AM +0100, Kevin Wolf wrote: > > Until now, @size has been mandatory for creating images with every > > driver. Maybe we should even have put it into BlockdevCreateOptions's > > base, because without a

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-28 Thread Daniel P . Berrangé
On Wed, Feb 28, 2024 at 11:17:37AM +0100, Kevin Wolf wrote: > Until now, @size has been mandatory for creating images with every > driver. Maybe we should even have put it into BlockdevCreateOptions's > base, because without a size, you're not really creating an image. NB, @size isn't mandatory

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-28 Thread Daniel P . Berrangé
On Wed, Feb 28, 2024 at 12:21:02PM +0100, Kevin Wolf wrote: > Am 28.02.2024 um 11:23 hat Daniel P. Berrangé geschrieben: > > On Wed, Feb 28, 2024 at 11:17:37AM +0100, Kevin Wolf wrote: > > > Am 28.02.2024 um 07:43 hat Markus Armbruster geschrieben: > > > > Yong Huang writes: > > > > > > > > > On

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-28 Thread Kevin Wolf
Am 28.02.2024 um 11:23 hat Daniel P. Berrangé geschrieben: > On Wed, Feb 28, 2024 at 11:17:37AM +0100, Kevin Wolf wrote: > > Am 28.02.2024 um 07:43 hat Markus Armbruster geschrieben: > > > Yong Huang writes: > > > > > > > On Wed, Feb 21, 2024 at 4:26 PM Markus Armbruster > > > > wrote: > > > >

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-28 Thread Daniel P . Berrangé
On Wed, Feb 28, 2024 at 11:17:37AM +0100, Kevin Wolf wrote: > Am 28.02.2024 um 07:43 hat Markus Armbruster geschrieben: > > Yong Huang writes: > > > > > On Wed, Feb 21, 2024 at 4:26 PM Markus Armbruster > > > wrote: > > > > > >> Yong Huang writes: > > >> > > >> > On Wed, Feb 21, 2024 at 2:43 

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-28 Thread Kevin Wolf
Am 28.02.2024 um 07:43 hat Markus Armbruster geschrieben: > Yong Huang writes: > > > On Wed, Feb 21, 2024 at 4:26 PM Markus Armbruster wrote: > > > >> Yong Huang writes: > >> > >> > On Wed, Feb 21, 2024 at 2:43 PM Markus Armbruster > >> wrote: > >> > > >> >> Hyman Huang writes: > >> >> > >>

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-27 Thread Markus Armbruster
Yong Huang writes: > On Wed, Feb 21, 2024 at 4:26 PM Markus Armbruster wrote: > >> Yong Huang writes: >> >> > On Wed, Feb 21, 2024 at 2:43 PM Markus Armbruster >> wrote: >> > >> >> Hyman Huang writes: >> >> >> >> > Add comment in detail for commit 433957bb7f (qapi: >> >> > Make parameter

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-21 Thread Yong Huang
On Wed, Feb 21, 2024 at 4:26 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Wed, Feb 21, 2024 at 2:43 PM Markus Armbruster > wrote: > > > >> Hyman Huang writes: > >> > >> > Add comment in detail for commit 433957bb7f (qapi: > >> > Make parameter 'file' optional for > >> >

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-21 Thread Markus Armbruster
Yong Huang writes: > On Wed, Feb 21, 2024 at 2:43 PM Markus Armbruster wrote: > >> Hyman Huang writes: >> >> > Add comment in detail for commit 433957bb7f (qapi: >> > Make parameter 'file' optional for >> > BlockdevCreateOptionsLUKS). >> > >> > Signed-off-by: Hyman Huang >> > --- >> >

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-20 Thread Yong Huang
On Wed, Feb 21, 2024 at 2:43 PM Markus Armbruster wrote: > Hyman Huang writes: > > > Add comment in detail for commit 433957bb7f (qapi: > > Make parameter 'file' optional for > > BlockdevCreateOptionsLUKS). > > > > Signed-off-by: Hyman Huang > > --- > > qapi/block-core.json | 20

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-20 Thread Markus Armbruster
Hyman Huang writes: > Add comment in detail for commit 433957bb7f (qapi: > Make parameter 'file' optional for > BlockdevCreateOptionsLUKS). > > Signed-off-by: Hyman Huang > --- > qapi/block-core.json | 20 +++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git