Re: [PATCH 04/14] hw/i386/vmport: Introduce vmx-version property

2020-03-10 Thread Liran Alon
On 10/03/2020 13:44, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:28:32PM +0200, Liran Alon wrote: On 10/03/2020 13:18, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:05:02PM +0200, Liran Alon wrote: On 10/03/2020 11:32, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at

Re: [PATCH 04/14] hw/i386/vmport: Introduce vmx-version property

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 01:28:32PM +0200, Liran Alon wrote: > > On 10/03/2020 13:18, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 01:05:02PM +0200, Liran Alon wrote: > > > On 10/03/2020 11:32, Michael S. Tsirkin wrote: > > > > On Tue, Mar 10, 2020 at 01:54:01AM +0200, Liran Alon wrote: >

Re: [PATCH 04/14] hw/i386/vmport: Introduce vmx-version property

2020-03-10 Thread Liran Alon
On 10/03/2020 13:18, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:05:02PM +0200, Liran Alon wrote: On 10/03/2020 11:32, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:54:01AM +0200, Liran Alon wrote: Instead of hard-coding the VMX version, make it a VMPORT object property.

Re: [PATCH 04/14] hw/i386/vmport: Introduce vmx-version property

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 01:05:02PM +0200, Liran Alon wrote: > > On 10/03/2020 11:32, Michael S. Tsirkin wrote: > > On Tue, Mar 10, 2020 at 01:54:01AM +0200, Liran Alon wrote: > > > Instead of hard-coding the VMX version, make it a VMPORT object property. > > > This would allow user to control

Re: [PATCH 04/14] hw/i386/vmport: Introduce vmx-version property

2020-03-10 Thread Liran Alon
On 10/03/2020 11:32, Michael S. Tsirkin wrote: On Tue, Mar 10, 2020 at 01:54:01AM +0200, Liran Alon wrote: Instead of hard-coding the VMX version, make it a VMPORT object property. This would allow user to control it's value via "-global vmport.vmx-version=X". Reviewed-by: Nikita Leshenko

Re: [PATCH 04/14] hw/i386/vmport: Introduce vmx-version property

2020-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2020 at 01:54:01AM +0200, Liran Alon wrote: > Instead of hard-coding the VMX version, make it a VMPORT object property. > This would allow user to control it's value via "-global > vmport.vmx-version=X". > > Reviewed-by: Nikita Leshenko > Signed-off-by: Liran Alon More detail