Re: [PATCH 06/25] hw/timer/cmsdk-apb-timer: Rename CMSDKAPBTIMER struct to CMSDKAPBTimer

2021-01-22 Thread Luc Michel
On 19:06 Thu 21 Jan , Peter Maydell wrote: > The state struct for the CMSDK APB timer device doesn't follow our > usual naming convention of camelcase -- "CMSDK" and "APB" are both > acronyms, but "TIMER" is not so should not be all-uppercase. > Globally rename the struct to "CMSDKAPBTimer"

Re: [PATCH 06/25] hw/timer/cmsdk-apb-timer: Rename CMSDKAPBTIMER struct to CMSDKAPBTimer

2021-01-21 Thread Philippe Mathieu-Daudé
On 1/21/21 8:06 PM, Peter Maydell wrote: > The state struct for the CMSDK APB timer device doesn't follow our > usual naming convention of camelcase -- "CMSDK" and "APB" are both > acronyms, but "TIMER" is not so should not be all-uppercase. > Globally rename the struct to "CMSDKAPBTimer"