Re: [PATCH 1/2] meson: introduce modules_arch

2021-09-23 Thread Paolo Bonzini
On 21/09/21 15:46, Jose R. Ziviani wrote: Alternatively, you could C-ify the contents of config-devices.mak, and embed them in the per-arch modinfo-*.c; and record CONFIG_* symbols for each module (e.g. '{ "CONFIG_QXL", "hw-display-qxl" }' from a 'module_config("CONFIG_QXL")' line in the global

Re: [PATCH 1/2] meson: introduce modules_arch

2021-09-21 Thread Gerd Hoffmann
On Tue, Sep 21, 2021 at 10:35:04AM -0300, Jose R. Ziviani wrote: > Hello!! > > On Tue, Sep 21, 2021 at 07:25:42AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > But, in anyway, I'll still need to store the target architecture that > > > can use such core module, like I did here in this patch.

Re: [PATCH 1/2] meson: introduce modules_arch

2021-09-21 Thread Jose R. Ziviani
Hello!! On Mon, Sep 20, 2021 at 09:03:28PM +0200, Paolo Bonzini wrote: > On 20/09/21 15:02, Jose R. Ziviani wrote: > > But, in anyway, I'll still need to store the target architecture that > > can use such core module, like I did here in this patch. Otherwise, > > if I compile different targets

Re: [PATCH 1/2] meson: introduce modules_arch

2021-09-21 Thread Jose R. Ziviani
Hello!! On Tue, Sep 21, 2021 at 07:25:42AM +0200, Gerd Hoffmann wrote: > Hi, > > > But, in anyway, I'll still need to store the target architecture that > > can use such core module, like I did here in this patch. Otherwise, > > if I compile different targets at the same time, I'll end up with

Re: [PATCH 1/2] meson: introduce modules_arch

2021-09-20 Thread Gerd Hoffmann
Hi, > But, in anyway, I'll still need to store the target architecture that > can use such core module, like I did here in this patch. Otherwise, > if I compile different targets at the same time, I'll end up with the > same problem of targets trying to load wrong modules. That all works just

Re: [PATCH 1/2] meson: introduce modules_arch

2021-09-20 Thread Paolo Bonzini
On 20/09/21 15:02, Jose R. Ziviani wrote: But, in anyway, I'll still need to store the target architecture that can use such core module, like I did here in this patch. Otherwise, if I compile different targets at the same time, I'll end up with the same problem of targets trying to load wrong

Re: [PATCH 1/2] meson: introduce modules_arch

2021-09-20 Thread Jose R. Ziviani
On Mon, Sep 20, 2021 at 07:15:32AM +0200, Gerd Hoffmann wrote: > Hi, > > > Yes, I really like your approach, makes more sense indeed. But, how do I > > get the core modules that other modules depend on? > > > > I see that Kconfig already has something in this line: > > > > config VGA (from

Re: [PATCH 1/2] meson: introduce modules_arch

2021-09-19 Thread Gerd Hoffmann
Hi, > Yes, I really like your approach, makes more sense indeed. But, how do I > get the core modules that other modules depend on? > > I see that Kconfig already has something in this line: > > config VGA (from hw/display) > bool > > config PCI (from hw/pci) > bool > > config QXL

Re: [PATCH 1/2] meson: introduce modules_arch

2021-09-17 Thread Jose R. Ziviani
Hello! On Fri, Sep 17, 2021 at 09:14:04AM +0200, Gerd Hoffmann wrote: > Hi, > > > This variable keeps track of all modules enabled for a target > > architecture. This will be used in modinfo to refine the > > architectures that can really load the .so to avoid errors. > > I think this is the

Re: [PATCH 1/2] meson: introduce modules_arch

2021-09-17 Thread Gerd Hoffmann
Hi, > This variable keeps track of all modules enabled for a target > architecture. This will be used in modinfo to refine the > architectures that can really load the .so to avoid errors. I think this is the wrong approach. The reason why modules are not loading is typically *not* the