Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-19 Thread Thomas Huth
On 15/04/2021 21.07, Philippe Mathieu-Daudé wrote: On 4/15/21 6:56 PM, Greg Kurz wrote: On Thu, 15 Apr 2021 18:45:45 +0200 Philippe Mathieu-Daudé wrote: On 4/15/21 3:30 PM, Greg Kurz wrote: On Thu, 15 Apr 2021 14:39:55 +0200 Philippe Mathieu-Daudé wrote: On 4/9/21 6:03 PM, Greg Kurz

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-16 Thread Greg Kurz
On Thu, 15 Apr 2021 21:07:33 +0200 Philippe Mathieu-Daudé wrote: > On 4/15/21 6:56 PM, Greg Kurz wrote: > > On Thu, 15 Apr 2021 18:45:45 +0200 > > Philippe Mathieu-Daudé wrote: > > > >> On 4/15/21 3:30 PM, Greg Kurz wrote: > >>> On Thu, 15 Apr 2021 14:39:55 +0200 > >>> Philippe Mathieu-Daudé

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/15/21 6:56 PM, Greg Kurz wrote: > On Thu, 15 Apr 2021 18:45:45 +0200 > Philippe Mathieu-Daudé wrote: > >> On 4/15/21 3:30 PM, Greg Kurz wrote: >>> On Thu, 15 Apr 2021 14:39:55 +0200 >>> Philippe Mathieu-Daudé wrote: >>> On 4/9/21 6:03 PM, Greg Kurz wrote: > Despite its simple name

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-15 Thread Greg Kurz
On Thu, 15 Apr 2021 18:45:45 +0200 Philippe Mathieu-Daudé wrote: > On 4/15/21 3:30 PM, Greg Kurz wrote: > > On Thu, 15 Apr 2021 14:39:55 +0200 > > Philippe Mathieu-Daudé wrote: > > > >> On 4/9/21 6:03 PM, Greg Kurz wrote: > >>> Despite its simple name and common usage of "getting a pointer to

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/15/21 3:30 PM, Greg Kurz wrote: > On Thu, 15 Apr 2021 14:39:55 +0200 > Philippe Mathieu-Daudé wrote: > >> On 4/9/21 6:03 PM, Greg Kurz wrote: >>> Despite its simple name and common usage of "getting a pointer to >>> the machine" in system-mode emulation, qdev_get_machine() has some >>>

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-15 Thread Greg Kurz
On Thu, 15 Apr 2021 14:39:55 +0200 Philippe Mathieu-Daudé wrote: > On 4/9/21 6:03 PM, Greg Kurz wrote: > > Despite its simple name and common usage of "getting a pointer to > > the machine" in system-mode emulation, qdev_get_machine() has some > > subtilities. > > > > First, it can be called

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/9/21 6:03 PM, Greg Kurz wrote: > Despite its simple name and common usage of "getting a pointer to > the machine" in system-mode emulation, qdev_get_machine() has some > subtilities. > > First, it can be called when running user-mode emulation : this is > because user-mode partly relies on

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-15 Thread Greg Kurz
On Tue, 13 Apr 2021 18:25:42 -0400 Eduardo Habkost wrote: > On Fri, Apr 09, 2021 at 06:03:38PM +0200, Greg Kurz wrote: > > Despite its simple name and common usage of "getting a pointer to > > the machine" in system-mode emulation, qdev_get_machine() has some > > subtilities. > > > > First, it

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-15 Thread Greg Kurz
On Sat, 10 Apr 2021 10:59:25 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > Despite its simple name and common usage of "getting a pointer to > > the machine" in system-mode emulation, qdev_get_machine() has some > > subtilities. > > > > First, it can be called when running user-mode

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-14 Thread Eduardo Habkost
On Fri, Apr 09, 2021 at 06:03:38PM +0200, Greg Kurz wrote: > Despite its simple name and common usage of "getting a pointer to > the machine" in system-mode emulation, qdev_get_machine() has some > subtilities. > > First, it can be called when running user-mode emulation : this is > because

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-10 Thread Markus Armbruster
Greg Kurz writes: > Despite its simple name and common usage of "getting a pointer to > the machine" in system-mode emulation, qdev_get_machine() has some > subtilities. > > First, it can be called when running user-mode emulation : this is > because user-mode partly relies on qdev to

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-10 Thread Greg Kurz
On Fri, 9 Apr 2021 16:14:41 -0400 Eduardo Habkost wrote: > On Fri, Apr 09, 2021 at 06:03:38PM +0200, Greg Kurz wrote: > [...] > > In order to avoid further subtle breakages like this, change the > > implentation of qdev_get_machine() to: > > - keep the existing behaviour of creating the dummy

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-09 Thread Thomas Huth
On 09/04/2021 18.03, Greg Kurz wrote: Despite its simple name and common usage of "getting a pointer to the machine" in system-mode emulation, qdev_get_machine() has some subtilities. First, it can be called when running user-mode emulation : this is because user-mode partly relies on qdev to

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-09 Thread Eduardo Habkost
On Fri, Apr 09, 2021 at 06:03:38PM +0200, Greg Kurz wrote: [...] > In order to avoid further subtle breakages like this, change the > implentation of qdev_get_machine() to: > - keep the existing behaviour of creating the dummy "container" > object for the user-mode case only ; > - abort() if the