Re: [PATCH 1/3] hw/misc: sifive_e_aon: Support the watchdog timer of HiFive 1 rev b.

2022-10-31 Thread Tommy Wu
Hi Alistair, Sorry for the late reply. Thank you for the great feedback! > Can you please keep all variable declarations at the top of the code block. I've fixed it in patch v2. > Does the guest not expect to read the values back? The devices : AON-LFROSC, AON-BACKUP, AON_PMU haven't been

Re: [PATCH 1/3] hw/misc: sifive_e_aon: Support the watchdog timer of HiFive 1 rev b.

2022-10-09 Thread Alistair Francis
On Thu, Sep 22, 2022 at 6:43 PM Tommy Wu wrote: > > The watchdog timer is in the always-on domain device of HiFive 1 rev b, > so this patch added the AON device to the sifive_e machine. This patch > only implemented the functionality of the watchdog timer. > > Signed-off-by: Tommy Wu > --- >

Re: [PATCH 1/3] hw/misc: sifive_e_aon: Support the watchdog timer of HiFive 1 rev b.

2022-09-27 Thread Frank Chang
Reviewed-by: Frank Chang On Thu, Sep 22, 2022 at 4:41 PM Tommy Wu wrote: > The watchdog timer is in the always-on domain device of HiFive 1 rev b, > so this patch added the AON device to the sifive_e machine. This patch > only implemented the functionality of the watchdog timer. > >