Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-10-04 Thread Si-Wei Liu
On 9/29/2022 12:13 AM, Michael S. Tsirkin wrote: On Wed, Sep 21, 2022 at 04:00:58PM -0700, Si-Wei Liu wrote: The spec doesn't explicitly say anything about that as far as I see. Here the spec is totally ruled by the (software artifact of) implementation rather than what a real device is

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-29 Thread Michael S. Tsirkin
On Wed, Sep 21, 2022 at 04:00:58PM -0700, Si-Wei Liu wrote: > > > >The spec doesn't explicitly say anything about that > > > > as far as I see. > > > Here the spec is totally ruled by the (software artifact of) > > > implementation rather than what a real device is expected to work with > > >

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-21 Thread Si-Wei Liu
On 9/16/2022 6:45 AM, Eugenio Perez Martin wrote: On Wed, Sep 14, 2022 at 5:44 PM Si-Wei Liu wrote: On 9/14/2022 2:57 PM, Eugenio Perez Martin wrote: On Wed, Sep 14, 2022 at 1:33 PM Si-Wei Liu wrote: On 9/14/2022 3:20 AM, Jason Wang wrote: On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-16 Thread Eugenio Perez Martin
On Wed, Sep 14, 2022 at 5:44 PM Si-Wei Liu wrote: > > > > On 9/14/2022 2:57 PM, Eugenio Perez Martin wrote: > > On Wed, Sep 14, 2022 at 1:33 PM Si-Wei Liu wrote: > >> > >> > >> On 9/14/2022 3:20 AM, Jason Wang wrote: > >>> On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez Martin > >>> wrote: >

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-14 Thread Jason Wang
On Wed, Sep 14, 2022 at 11:44 PM Si-Wei Liu wrote: > > > > On 9/14/2022 2:57 PM, Eugenio Perez Martin wrote: > > On Wed, Sep 14, 2022 at 1:33 PM Si-Wei Liu wrote: > >> > >> > >> On 9/14/2022 3:20 AM, Jason Wang wrote: > >>> On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez Martin > >>> wrote: >

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-14 Thread Jason Wang
On Wed, Sep 14, 2022 at 7:33 PM Si-Wei Liu wrote: > > > > On 9/14/2022 3:20 AM, Jason Wang wrote: > > On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez Martin > > wrote: > >> On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: > >>> On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > On Wed, Sep

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-14 Thread Si-Wei Liu
On 9/14/2022 2:57 PM, Eugenio Perez Martin wrote: On Wed, Sep 14, 2022 at 1:33 PM Si-Wei Liu wrote: On 9/14/2022 3:20 AM, Jason Wang wrote: On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez Martin wrote: On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: On Fri, Sep 9, 2022 at 2:38 PM Jason

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-14 Thread Eugenio Perez Martin
On Wed, Sep 14, 2022 at 1:33 PM Si-Wei Liu wrote: > > > > On 9/14/2022 3:20 AM, Jason Wang wrote: > > On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez Martin > > wrote: > >> On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: > >>> On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > On Wed, Sep

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-14 Thread Si-Wei Liu
On 9/14/2022 3:20 AM, Jason Wang wrote: On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez Martin wrote: On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: To have enabled vlans at device

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-14 Thread Eugenio Perez Martin
On Fri, Sep 9, 2022 at 10:38 AM Michael S. Tsirkin wrote: > > On Fri, Sep 09, 2022 at 10:01:16AM +0200, Eugenio Perez Martin wrote: > > On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: > > > > > > On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > > > > > > > > On Wed, Sep 7, 2022 at 12:36 AM

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-14 Thread Eugenio Perez Martin
On Wed, Sep 14, 2022 at 4:20 AM Jason Wang wrote: > > On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez Martin > wrote: > > > > On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: > > > > > > On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > > > > > > > > On Wed, Sep 7, 2022 at 12:36 AM Eugenio

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-13 Thread Jason Wang
On Fri, Sep 9, 2022 at 4:38 PM Michael S. Tsirkin wrote: > > On Fri, Sep 09, 2022 at 10:01:16AM +0200, Eugenio Perez Martin wrote: > > On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: > > > > > > On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > > > > > > > > On Wed, Sep 7, 2022 at 12:36 AM

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-13 Thread Jason Wang
On Fri, Sep 9, 2022 at 4:02 PM Eugenio Perez Martin wrote: > > On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: > > > > On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > > > > > > On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: > > > > > > > > To have enabled vlans at device startup may

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-09 Thread Michael S. Tsirkin
On Fri, Sep 09, 2022 at 10:01:16AM +0200, Eugenio Perez Martin wrote: > On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: > > > > On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > > > > > > On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: > > > > > > > > To have enabled vlans at device

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-09 Thread Eugenio Perez Martin
On Fri, Sep 9, 2022 at 8:40 AM Jason Wang wrote: > > On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > > > > On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: > > > > > > To have enabled vlans at device startup may happen in the destination of > > > a live migration, so this configuration

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-09 Thread Jason Wang
On Fri, Sep 9, 2022 at 2:38 PM Jason Wang wrote: > > On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: > > > > To have enabled vlans at device startup may happen in the destination of > > a live migration, so this configuration must be restored. > > > > At this moment the code is not

Re: [PATCH 2/3] vdpa: load vlan configuration at NIC startup

2022-09-09 Thread Jason Wang
On Wed, Sep 7, 2022 at 12:36 AM Eugenio Pérez wrote: > > To have enabled vlans at device startup may happen in the destination of > a live migration, so this configuration must be restored. > > At this moment the code is not accessible, since SVQ refuses to start if > vlan feature is exposed by