Re: [PATCH 24/30] bsd-user/signal.c: setup_frame

2022-01-16 Thread Warner Losh
On Sun, Jan 16, 2022 at 11:58 PM Warner Losh wrote: > > +if (!lock_user_struct(VERIFY_WRITE, frame, frame_addr, 0)) { >> > +goto give_sigsegv; >> >> FreeBSD for Arm (haven't checked other BSDs or other archs) >> gives a SIGILL for the "can't write signal frame to stack" >> case, I

Re: [PATCH 24/30] bsd-user/signal.c: setup_frame

2022-01-16 Thread Warner Losh
On Fri, Jan 14, 2022 at 4:40 AM Peter Maydell wrote: > On Sun, 9 Jan 2022 at 16:36, Warner Losh wrote: > > > > setup_frame sets up a signalled stack frame. Associated routines to > > extract the pointer to the stack frame and to support alternate stacks. > > > > Signed-off-by: Stacey Son > >

Re: [PATCH 24/30] bsd-user/signal.c: setup_frame

2022-01-14 Thread Peter Maydell
On Sun, 9 Jan 2022 at 16:36, Warner Losh wrote: > > setup_frame sets up a signalled stack frame. Associated routines to > extract the pointer to the stack frame and to support alternate stacks. > > Signed-off-by: Stacey Son > Signed-off-by: Kyle Evans > Signed-off-by: Warner Losh > --- >