Re: [PATCH 6/8] tcg/aarch64: Support TCG_TARGET_SIGNED_ADDR32

2021-10-13 Thread Richard Henderson
On 10/11/21 3:28 AM, Alex Bennée wrote: +if (TARGET_LONG_BITS == 64) { +return 3; /* LSL #0 */ +} else if (signed_addr32) { +return 6; /* SXTW */ +} else { +return 2; /* UXTW */ +} +} If this is is going to be a magic number we pass into our code

Re: [PATCH 6/8] tcg/aarch64: Support TCG_TARGET_SIGNED_ADDR32

2021-10-11 Thread Richard Henderson
On 10/11/21 3:28 AM, Alex Bennée wrote: Richard Henderson writes: AArch64 has both sign and zero-extending addressing modes, which means that either treatment of guest addresses is equally efficient. Enabling this for AArch64 gives us testing of the feature in CI. So which guests front

Re: [PATCH 6/8] tcg/aarch64: Support TCG_TARGET_SIGNED_ADDR32

2021-10-11 Thread Alex Bennée
Richard Henderson writes: > AArch64 has both sign and zero-extending addressing modes, which > means that either treatment of guest addresses is equally efficient. > Enabling this for AArch64 gives us testing of the feature in CI. So which guests front ends will exercise this backend? I