Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-15 Thread Nir Soffer
On Wed, Jul 15, 2020 at 4:42 PM Kevin Wolf wrote: > > Am 15.07.2020 um 15:22 hat Nir Soffer geschrieben: > > On Mon, Jul 13, 2020 at 7:56 PM Kevin Wolf wrote: > > > > > > Am 13.07.2020 um 18:33 hat Nir Soffer geschrieben: > > > > On Fri, Jul 10, 2020 at 5:22 PM Kevin Wolf wrote: > > > > > > > >

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-15 Thread Daniel P . Berrangé
On Wed, Jul 15, 2020 at 04:22:06PM +0300, Nir Soffer wrote: > On Mon, Jul 13, 2020 at 7:56 PM Kevin Wolf wrote: > > > > Am 13.07.2020 um 18:33 hat Nir Soffer geschrieben: > > > On Fri, Jul 10, 2020 at 5:22 PM Kevin Wolf wrote: > > > > > > > > Unaligned requests will automatically be aligned to

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-15 Thread Kevin Wolf
Am 15.07.2020 um 15:22 hat Nir Soffer geschrieben: > On Mon, Jul 13, 2020 at 7:56 PM Kevin Wolf wrote: > > > > Am 13.07.2020 um 18:33 hat Nir Soffer geschrieben: > > > On Fri, Jul 10, 2020 at 5:22 PM Kevin Wolf wrote: > > > > > > > > Unaligned requests will automatically be aligned to

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-15 Thread Nir Soffer
On Mon, Jul 13, 2020 at 7:56 PM Kevin Wolf wrote: > > Am 13.07.2020 um 18:33 hat Nir Soffer geschrieben: > > On Fri, Jul 10, 2020 at 5:22 PM Kevin Wolf wrote: > > > > > > Unaligned requests will automatically be aligned to bl.request_alignment > > > and we don't want to extend requests to access

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-15 Thread Kevin Wolf
Am 14.07.2020 um 18:22 hat Max Reitz geschrieben: > On 14.07.20 13:08, Kevin Wolf wrote: > > Am 14.07.2020 um 11:56 hat Max Reitz geschrieben: > >> On 13.07.20 16:29, Kevin Wolf wrote: > >>> Am 13.07.2020 um 13:19 hat Max Reitz geschrieben: > On 10.07.20 16:21, Kevin Wolf wrote: > >

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-14 Thread Max Reitz
On 14.07.20 13:08, Kevin Wolf wrote: > Am 14.07.2020 um 11:56 hat Max Reitz geschrieben: >> On 13.07.20 16:29, Kevin Wolf wrote: >>> Am 13.07.2020 um 13:19 hat Max Reitz geschrieben: On 10.07.20 16:21, Kevin Wolf wrote: > Unaligned requests will automatically be aligned to

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-14 Thread Kevin Wolf
Am 14.07.2020 um 11:56 hat Max Reitz geschrieben: > On 13.07.20 16:29, Kevin Wolf wrote: > > Am 13.07.2020 um 13:19 hat Max Reitz geschrieben: > >> On 10.07.20 16:21, Kevin Wolf wrote: > >>> Unaligned requests will automatically be aligned to bl.request_alignment > >>> and we don't want to extend

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-14 Thread Max Reitz
On 13.07.20 16:29, Kevin Wolf wrote: > Am 13.07.2020 um 13:19 hat Max Reitz geschrieben: >> On 10.07.20 16:21, Kevin Wolf wrote: >>> Unaligned requests will automatically be aligned to bl.request_alignment >>> and we don't want to extend requests to access space beyond the end of >>> the image, so

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-13 Thread Kevin Wolf
Am 13.07.2020 um 18:33 hat Nir Soffer geschrieben: > On Fri, Jul 10, 2020 at 5:22 PM Kevin Wolf wrote: > > > > Unaligned requests will automatically be aligned to bl.request_alignment > > and we don't want to extend requests to access space beyond the end of > > the image, so it's required that

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-13 Thread Nir Soffer
On Fri, Jul 10, 2020 at 5:22 PM Kevin Wolf wrote: > > Unaligned requests will automatically be aligned to bl.request_alignment > and we don't want to extend requests to access space beyond the end of > the image, so it's required that the image size is aligned. > > With write requests, this could

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-13 Thread Kevin Wolf
Am 13.07.2020 um 13:19 hat Max Reitz geschrieben: > On 10.07.20 16:21, Kevin Wolf wrote: > > Unaligned requests will automatically be aligned to bl.request_alignment > > and we don't want to extend requests to access space beyond the end of > > the image, so it's required that the image size is

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-13 Thread Max Reitz
On 13.07.20 13:19, Max Reitz wrote: > On 10.07.20 16:21, Kevin Wolf wrote: >> Unaligned requests will automatically be aligned to bl.request_alignment >> and we don't want to extend requests to access space beyond the end of >> the image, so it's required that the image size is aligned. >> >> With

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-13 Thread Max Reitz
On 10.07.20 16:21, Kevin Wolf wrote: > Unaligned requests will automatically be aligned to bl.request_alignment > and we don't want to extend requests to access space beyond the end of > the image, so it's required that the image size is aligned. > > With write requests, this could cause

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-10 Thread Eric Blake
On 7/10/20 9:21 AM, Kevin Wolf wrote: Unaligned requests will automatically be aligned to bl.request_alignment and we don't want to extend requests to access space beyond the end of the image, so it's required that the image size is aligned. Yep, that's what I've already done on nbd images.