Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-18 Thread Cornelia Huck
On Wed, 18 Nov 2020 10:38:00 +0100 Thomas Huth wrote: > On 18/11/2020 09.51, Cornelia Huck wrote: > > The zPCI group and function structures are big endian. However, we do > > not consistently store them as big endian locally, and are missing some > > conversions. > > > > Let's just store the

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-18 Thread Thomas Huth
On 18/11/2020 09.51, Cornelia Huck wrote: > The zPCI group and function structures are big endian. However, we do > not consistently store them as big endian locally, and are missing some > conversions. > > Let's just store the structures as host endian instead and convert to > big endian when

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-18 Thread Cornelia Huck
On Wed, 18 Nov 2020 09:51:54 +0100 Cornelia Huck wrote: [This is obviously a v2. Should not send patches before the first coffee :/] > The zPCI group and function structures are big endian. However, we do > not consistently store them as big endian locally, and are missing some > conversions. >

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Cornelia Huck
On Tue, 17 Nov 2020 14:49:53 -0500 Matthew Rosato wrote: > On 11/17/20 2:21 PM, Thomas Huth wrote: > > On 17/11/2020 18.13, Cornelia Huck wrote: > >> zPCI control blocks are big endian, we need to take care that we > >> do proper accesses in order not to break tcg guests on little endian > >>

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Matthew Rosato
On 11/17/20 2:21 PM, Thomas Huth wrote: On 17/11/2020 18.13, Cornelia Huck wrote: zPCI control blocks are big endian, we need to take care that we do proper accesses in order not to break tcg guests on little endian hosts. Fixes: 28dc86a07299 ("s390x/pci: use a PCI Group structure") Fixes:

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Thomas Huth
On 17/11/2020 19.49, Philippe Mathieu-Daudé wrote: > On 11/17/20 7:39 PM, Thomas Huth wrote: >> On 17/11/2020 19.30, Philippe Mathieu-Daudé wrote: >>> On 11/17/20 7:19 PM, Matthew Rosato wrote: On 11/17/20 12:59 PM, Philippe Mathieu-Daudé wrote: > On 11/17/20 6:13 PM, Cornelia Huck wrote:

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Thomas Huth
On 17/11/2020 18.13, Cornelia Huck wrote: > zPCI control blocks are big endian, we need to take care that we > do proper accesses in order not to break tcg guests on little endian > hosts. > > Fixes: 28dc86a07299 ("s390x/pci: use a PCI Group structure") > Fixes: 9670ee752727 ("s390x/pci: use a

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Matthew Rosato
On 11/17/20 12:13 PM, Cornelia Huck wrote: zPCI control blocks are big endian, we need to take care that we do proper accesses in order not to break tcg guests on little endian hosts. Fixes: 28dc86a07299 ("s390x/pci: use a PCI Group structure") Fixes: 9670ee752727 ("s390x/pci: use a PCI

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Philippe Mathieu-Daudé
On 11/17/20 7:39 PM, Thomas Huth wrote: > On 17/11/2020 19.30, Philippe Mathieu-Daudé wrote: >> On 11/17/20 7:19 PM, Matthew Rosato wrote: >>> On 11/17/20 12:59 PM, Philippe Mathieu-Daudé wrote: On 11/17/20 6:13 PM, Cornelia Huck wrote: > zPCI control blocks are big endian, we need to

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Thomas Huth
On 17/11/2020 19.30, Philippe Mathieu-Daudé wrote: > On 11/17/20 7:19 PM, Matthew Rosato wrote: >> On 11/17/20 12:59 PM, Philippe Mathieu-Daudé wrote: >>> On 11/17/20 6:13 PM, Cornelia Huck wrote: zPCI control blocks are big endian, we need to take care that we do proper accesses in

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Philippe Mathieu-Daudé
On 11/17/20 7:19 PM, Matthew Rosato wrote: > On 11/17/20 12:59 PM, Philippe Mathieu-Daudé wrote: >> On 11/17/20 6:13 PM, Cornelia Huck wrote: >>> zPCI control blocks are big endian, we need to take care that we >>> do proper accesses in order not to break tcg guests on little endian >>> hosts. >>>

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Matthew Rosato
On 11/17/20 12:59 PM, Philippe Mathieu-Daudé wrote: On 11/17/20 6:13 PM, Cornelia Huck wrote: zPCI control blocks are big endian, we need to take care that we do proper accesses in order not to break tcg guests on little endian hosts. Fixes: 28dc86a07299 ("s390x/pci: use a PCI Group

Re: [PATCH for-5.2] s390x/pci: fix endianness issues

2020-11-17 Thread Philippe Mathieu-Daudé
On 11/17/20 6:13 PM, Cornelia Huck wrote: > zPCI control blocks are big endian, we need to take care that we > do proper accesses in order not to break tcg guests on little endian > hosts. > > Fixes: 28dc86a07299 ("s390x/pci: use a PCI Group structure") > Fixes: 9670ee752727 ("s390x/pci: use a