Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-28 Thread Michael S. Tsirkin
On Fri, May 26, 2023 at 09:55:22AM +0200, Juan Quintela wrote: > Jiri Denemark wrote: > > On Thu, May 11, 2023 at 13:43:47 +0200, Juan Quintela wrote: > >> "Michael S. Tsirkin" wrote: > >> > >> [Added libvirt people to the party, see the end of the message ] > > > > Sorry, I'm not that much

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-26 Thread Juan Quintela
Jiri Denemark wrote: > On Thu, May 11, 2023 at 13:43:47 +0200, Juan Quintela wrote: >> "Michael S. Tsirkin" wrote: >> >> [Added libvirt people to the party, see the end of the message ] > > Sorry, I'm not that much into parties :-) > >> That would fix the: >> >> qemu-8.0 -M pc-7.2 ->

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-22 Thread Jiri Denemark
On Thu, May 11, 2023 at 13:43:47 +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > [Added libvirt people to the party, see the end of the message ] Sorry, I'm not that much into parties :-) > That would fix the: > > qemu-8.0 -M pc-7.2 -> qemu-8.0.1 -M pc-7.2 > > It is worth it?

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-18 Thread Juan Quintela
"Michael S. Tsirkin" wrote: [adding cleber] > On Thu, May 18, 2023 at 09:27:01AM -0400, Peter Xu wrote: >> One thing we can also do to avoid it in the future is simply having someone >> do this check around each softfreeze (and we'll also need maintainers be >> careful on merging anything

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-18 Thread Juan Quintela
Peter Xu wrote: > On Thu, May 18, 2023 at 01:33:43PM +0200, Juan Quintela wrote: >> See patch for documentation: >> >> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg03288.html >> >> Basically, the best we can do is: >> - get the patch posted. Fixes everything except: >> (3)

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-18 Thread Michael S. Tsirkin
On Thu, May 18, 2023 at 09:27:01AM -0400, Peter Xu wrote: > On Thu, May 18, 2023 at 01:33:43PM +0200, Juan Quintela wrote: > > Michael Tokarev wrote: > > > 11.05.2023 11:40, Juan Quintela wrote: > > >> Fiona Ebner wrote: > > > ... > > >>> Closes:

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-18 Thread Peter Xu
On Thu, May 18, 2023 at 01:33:43PM +0200, Juan Quintela wrote: > Michael Tokarev wrote: > > 11.05.2023 11:40, Juan Quintela wrote: > >> Fiona Ebner wrote: > > ... > >>> Closes: https://gitlab.com/qemu-project/qemu/-/issues/1576 > >>> > >>> AFAICT, this breaks (forward) migration from 8.0 to 8.0

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-18 Thread Juan Quintela
Michael Tokarev wrote: > 11.05.2023 11:40, Juan Quintela wrote: >> Fiona Ebner wrote: > ... >>> Closes: https://gitlab.com/qemu-project/qemu/-/issues/1576 >>> >>> AFAICT, this breaks (forward) migration from 8.0 to 8.0 + this patch >>> when using machine type <= 7.2. That is because after this

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-18 Thread Michael Tokarev
11.05.2023 11:40, Juan Quintela wrote: Fiona Ebner wrote: ... Closes: https://gitlab.com/qemu-project/qemu/-/issues/1576 AFAICT, this breaks (forward) migration from 8.0 to 8.0 + this patch when using machine type <= 7.2. That is because after this patch, when using machine type <= 7.2, the

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-11 Thread Michael S. Tsirkin
On Thu, May 11, 2023 at 01:43:47PM +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > [Added libvirt people to the party, see the end of the message ] > > > On Thu, May 11, 2023 at 10:27:35AM +0200, Fiona Ebner wrote: > >> Am 03.05.23 um 02:27 schrieb Leonardo Bras: > >> > Since it's

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-11 Thread Juan Quintela
"Michael S. Tsirkin" wrote: [Added libvirt people to the party, see the end of the message ] > On Thu, May 11, 2023 at 10:27:35AM +0200, Fiona Ebner wrote: >> Am 03.05.23 um 02:27 schrieb Leonardo Bras: >> > Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK >> > set for

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-11 Thread Michael S. Tsirkin
On Thu, May 11, 2023 at 10:27:35AM +0200, Fiona Ebner wrote: > Am 03.05.23 um 02:27 schrieb Leonardo Bras: > > Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK > > set for machine types < 8.0 will cause migration to fail if the target > > QEMU version is < 8.0.0 : > > > >

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-11 Thread Juan Quintela
Fiona Ebner wrote: > Am 03.05.23 um 02:27 schrieb Leonardo Bras: >> Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK >> set for machine types < 8.0 will cause migration to fail if the target >> QEMU version is < 8.0.0 : >> >> qemu-system-x86_64: get_pci_config_device: Bad

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-11 Thread Fiona Ebner
Am 03.05.23 um 02:27 schrieb Leonardo Bras: > Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK > set for machine types < 8.0 will cause migration to fail if the target > QEMU version is < 8.0.0 : > > qemu-system-x86_64: get_pci_config_device: Bad config data: i=0x10a read:

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-10 Thread Juan Quintela
Michael Tokarev wrote: > 03.05.2023 03:27, Leonardo Bras пишет: >> Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK >> set for machine types < 8.0 will cause migration to fail if the target >> QEMU version is < 8.0.0 : >> qemu-system-x86_64: get_pci_config_device: Bad config

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-10 Thread Michael S. Tsirkin
On Wed, May 10, 2023 at 07:29:40PM +0300, Michael Tokarev wrote: > 03.05.2023 03:27, Leonardo Bras пишет: > > Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK > > set for machine types < 8.0 will cause migration to fail if the target > > QEMU version is < 8.0.0 : > > > >

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-10 Thread Michael Tokarev
03.05.2023 03:27, Leonardo Bras пишет: Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK set for machine types < 8.0 will cause migration to fail if the target QEMU version is < 8.0.0 : qemu-system-x86_64: get_pci_config_device: Bad config data: i=0x10a read: 40 device: 0

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-09 Thread Juan Quintela
Leonardo Bras wrote: > Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK > set for machine types < 8.0 will cause migration to fail if the target > QEMU version is < 8.0.0 : > > qemu-system-x86_64: get_pci_config_device: Bad config data: i=0x10a read: 40 > device: 0 cmask:

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-09 Thread Michael S. Tsirkin
On Tue, May 09, 2023 at 07:01:53AM -0700, Peter Xu wrote: > On Tue, May 02, 2023 at 09:27:02PM -0300, Leonardo Bras wrote: > > Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK > > set for machine types < 8.0 will cause migration to fail if the target > > QEMU version is <

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-09 Thread Peter Xu
On Tue, May 02, 2023 at 09:27:02PM -0300, Leonardo Bras wrote: > Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK > set for machine types < 8.0 will cause migration to fail if the target > QEMU version is < 8.0.0 : > > qemu-system-x86_64: get_pci_config_device: Bad config

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-03 Thread Juan Quintela
Leonardo Bras wrote: > Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK > set for machine types < 8.0 will cause migration to fail if the target > QEMU version is < 8.0.0 : > > qemu-system-x86_64: get_pci_config_device: Bad config data: i=0x10a read: 40 > device: 0 cmask:

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-03 Thread Leonardo Bras Soares Passos
On Wed, May 3, 2023 at 6:49 AM Jonathan Cameron wrote: > > On Tue, 2 May 2023 21:27:02 -0300 > Leonardo Bras wrote: > > > Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK > > set for machine types < 8.0 will cause migration to fail if the target > > QEMU version is < 8.0.0

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-03 Thread Peter Xu
On Tue, May 02, 2023 at 09:27:02PM -0300, Leonardo Bras wrote: > Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK > set for machine types < 8.0 will cause migration to fail if the target > QEMU version is < 8.0.0 : > > qemu-system-x86_64: get_pci_config_device: Bad config

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-03 Thread Jonathan Cameron via
On Tue, 2 May 2023 21:27:02 -0300 Leonardo Bras wrote: > Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK > set for machine types < 8.0 will cause migration to fail if the target > QEMU version is < 8.0.0 : > > qemu-system-x86_64: get_pci_config_device: Bad config data: