Re: [PATCH v1 14/24] vfio-user: get and set IRQs

2023-02-01 Thread John Johnson
> On Dec 13, 2022, at 8:39 AM, Cédric Le Goater wrote: > > On 11/9/22 00:13, John Johnson wrote: >> >> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c >> index 7abe44e..be39a4e 100644 >> --- a/hw/vfio/pci.c >> +++ b/hw/vfio/pci.c >> @@ -713,7 +713,8 @@ retry: >> ret =

Re: [PATCH v1 14/24] vfio-user: get and set IRQs

2022-12-13 Thread John Johnson
> On Dec 13, 2022, at 8:39 AM, Cédric Le Goater wrote: > > On 11/9/22 00:13, John Johnson wrote: >> >> + >> +/* must send all valid FDs or all invalid FDs in single msg */ > > why is that ? > This has to do with how VFIO sends FDs to the kernel. The ioctl() i/f has an

Re: [PATCH v1 14/24] vfio-user: get and set IRQs

2022-12-13 Thread Cédric Le Goater
On 11/9/22 00:13, John Johnson wrote: Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/vfio/pci.c | 7 ++- hw/vfio/user-protocol.h | 25 + hw/vfio/user.c | 135

Re: [PATCH v1 14/24] vfio-user: get and set IRQs

2022-12-12 Thread John Johnson
> On Dec 9, 2022, at 9:29 AM, John Levon wrote: > > On Tue, Nov 08, 2022 at 03:13:36PM -0800, John Johnson wrote: > >> +static int vfio_user_io_get_irq_info(VFIODevice *vbasedev, >> + struct vfio_irq_info *irq) >> +{ >> +int ret; >> + >> +ret =

Re: [PATCH v1 14/24] vfio-user: get and set IRQs

2022-12-09 Thread John Levon
On Tue, Nov 08, 2022 at 03:13:36PM -0800, John Johnson wrote: > +static int vfio_user_io_get_irq_info(VFIODevice *vbasedev, > + struct vfio_irq_info *irq) > +{ > +int ret; > + > +ret = vfio_user_get_irq_info(vbasedev->proxy, irq); > +if (ret) { > +