Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-27 Thread Alistair Francis
On Wed, Sep 25, 2019 at 2:00 AM Markus Armbruster wrote: > > Alistair Francis writes: > > > On Mon, Sep 23, 2019 at 2:46 PM Peter Maydell > > wrote: > >> > >> On Fri, 20 Sep 2019 at 23:23, Alistair Francis > >> wrote: > >> > On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: > >> > > I don't

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-25 Thread Philippe Mathieu-Daudé
On 9/25/19 2:55 AM, Alistair Francis wrote: > On Tue, Sep 24, 2019 at 2:32 AM Philippe Mathieu-Daudé > wrote: >> >> On 9/23/19 11:46 PM, Peter Maydell wrote: >>> On Fri, 20 Sep 2019 at 23:23, Alistair Francis wrote: On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: > I don't think we

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-25 Thread Markus Armbruster
Alistair Francis writes: > On Mon, Sep 23, 2019 at 2:46 PM Peter Maydell > wrote: >> >> On Fri, 20 Sep 2019 at 23:23, Alistair Francis wrote: >> > On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: >> > > I don't think we should mirror what is used on ARM virt board to >> > > create 2 flash

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-24 Thread Alistair Francis
On Tue, Sep 24, 2019 at 2:32 AM Philippe Mathieu-Daudé wrote: > > On 9/23/19 11:46 PM, Peter Maydell wrote: > > On Fri, 20 Sep 2019 at 23:23, Alistair Francis wrote: > >> On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: > >>> I don't think we should mirror what is used on ARM virt board to >

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-24 Thread Alistair Francis
On Mon, Sep 23, 2019 at 2:46 PM Peter Maydell wrote: > > On Fri, 20 Sep 2019 at 23:23, Alistair Francis wrote: > > On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: > > > I don't think we should mirror what is used on ARM virt board to > > > create 2 flash for sifive_u. For ARM virt, there are 2

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-24 Thread Laszlo Ersek
On 09/24/19 11:32, Philippe Mathieu-Daudé wrote: > On 9/23/19 11:46 PM, Peter Maydell wrote: >> On Fri, 20 Sep 2019 at 23:23, Alistair Francis wrote: >>> On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: I don't think we should mirror what is used on ARM virt board to create 2 flash for

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-24 Thread Philippe Mathieu-Daudé
On 9/23/19 11:46 PM, Peter Maydell wrote: > On Fri, 20 Sep 2019 at 23:23, Alistair Francis wrote: >> On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: >>> I don't think we should mirror what is used on ARM virt board to >>> create 2 flash for sifive_u. For ARM virt, there are 2 flashes because

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-23 Thread Peter Maydell
On Fri, 20 Sep 2019 at 23:23, Alistair Francis wrote: > On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: > > I don't think we should mirror what is used on ARM virt board to > > create 2 flash for sifive_u. For ARM virt, there are 2 flashes because > > they need distinguish secure and

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-23 Thread Alistair Francis
On Sat, Sep 21, 2019 at 7:15 PM Bin Meng wrote: > > On Sat, Sep 21, 2019 at 6:16 AM Alistair Francis wrote: > > > > On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: > > > > > > On Fri, Sep 20, 2019 at 6:36 AM Alistair Francis > > > wrote: > > > > > > > > Add the CFI01 PFlash to the RISC-V virt

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-21 Thread Bin Meng
On Sat, Sep 21, 2019 at 6:16 AM Alistair Francis wrote: > > On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: > > > > On Fri, Sep 20, 2019 at 6:36 AM Alistair Francis > > wrote: > > > > > > Add the CFI01 PFlash to the RISC-V virt board. This is the same PFlash > > > from the ARM Virt board and

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-20 Thread Alistair Francis
On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote: > > On Fri, Sep 20, 2019 at 6:36 AM Alistair Francis > wrote: > > > > Add the CFI01 PFlash to the RISC-V virt board. This is the same PFlash > > from the ARM Virt board and the implementation is based on the ARM Virt > > board. This allows users

Re: [PATCH v1 5/6] riscv/virt: Add the PFlash CFI01 device

2019-09-19 Thread Bin Meng
On Fri, Sep 20, 2019 at 6:36 AM Alistair Francis wrote: > > Add the CFI01 PFlash to the RISC-V virt board. This is the same PFlash > from the ARM Virt board and the implementation is based on the ARM Virt > board. This allows users to specify flash files from the command line. > > Signed-off-by: