Re: [PATCH v22 QEMU 3/5] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-04-27 Thread David Hildenbrand
On 27.04.20 17:57, Alexander Duyck wrote: > On Mon, Apr 27, 2020 at 8:11 AM David Hildenbrand wrote: >> >> On 27.04.20 17:08, Alexander Duyck wrote: >>> On Mon, Apr 27, 2020 at 1:15 AM David Hildenbrand wrote: There is only one wrong comment remaining I think. Something like

Re: [PATCH v22 QEMU 3/5] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-04-27 Thread Alexander Duyck
On Mon, Apr 27, 2020 at 8:11 AM David Hildenbrand wrote: > > On 27.04.20 17:08, Alexander Duyck wrote: > > On Mon, Apr 27, 2020 at 1:15 AM David Hildenbrand wrote: > >> > >> There is only one wrong comment remaining I think. Something like > >> > >> diff --git a/hw/virtio/virtio-balloon.c

Re: [PATCH v22 QEMU 3/5] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-04-27 Thread David Hildenbrand
On 27.04.20 17:08, Alexander Duyck wrote: > On Mon, Apr 27, 2020 at 1:15 AM David Hildenbrand wrote: >> >> There is only one wrong comment remaining I think. Something like >> >> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c >> index a1d6fb52c8..1b2127c04c 100644 >> ---

Re: [PATCH v22 QEMU 3/5] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-04-27 Thread Alexander Duyck
On Mon, Apr 27, 2020 at 1:15 AM David Hildenbrand wrote: > > There is only one wrong comment remaining I think. Something like > > diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c > index a1d6fb52c8..1b2127c04c 100644 > --- a/hw/virtio/virtio-balloon.c > +++

Re: [PATCH v22 QEMU 3/5] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-04-27 Thread David Hildenbrand
On 24.04.20 18:50, Alexander Duyck wrote: > From: Alexander Duyck > > In an upcoming patch a feature named Free Page Reporting is about to be > added. In order to avoid any confusion we should drop the use of the word > 'report' when referring to Free Page Hinting. So what this patch does is go