Re: [PATCH v4] hw/rtc/mc146818rtc: Make this rtc device target independent

2023-01-02 Thread Thomas Huth
On 02/01/2023 17.47, Bernhard Beschow wrote: Am 2. Januar 2023 16:09:08 UTC schrieb Thomas Huth : On 02/01/2023 14.36, Thomas Huth wrote: On 31/12/2022 00.45, Bernhard Beschow wrote: Am 29. Dezember 2022 10:58:48 UTC schrieb Thomas Huth : [...] static uint32_t

Re: [PATCH v4] hw/rtc/mc146818rtc: Make this rtc device target independent

2023-01-02 Thread Bernhard Beschow
Am 2. Januar 2023 16:09:08 UTC schrieb Thomas Huth : >On 02/01/2023 14.36, Thomas Huth wrote: >> On 31/12/2022 00.45, Bernhard Beschow wrote: >>> >>> Am 29. Dezember 2022 10:58:48 UTC schrieb Thomas Huth : >[...] static uint32_t rtc_periodic_clock_ticks(RTCState *s) { @@ -922,14

Re: [PATCH v4] hw/rtc/mc146818rtc: Make this rtc device target independent

2023-01-02 Thread Thomas Huth
On 02/01/2023 14.36, Thomas Huth wrote: On 31/12/2022 00.45, Bernhard Beschow wrote: Am 29. Dezember 2022 10:58:48 UTC schrieb Thomas Huth : [...] static uint32_t rtc_periodic_clock_ticks(RTCState *s) { @@ -922,14 +911,15 @@ static void rtc_realizefn(DeviceState *dev, Error **errp)

Re: [PATCH v4] hw/rtc/mc146818rtc: Make this rtc device target independent

2023-01-02 Thread Thomas Huth
On 31/12/2022 00.45, Bernhard Beschow wrote: Am 29. Dezember 2022 10:58:48 UTC schrieb Thomas Huth : The only reason for this code being target dependent is the apic-related code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather simple, we can easily move them into a

Re: [PATCH v4] hw/rtc/mc146818rtc: Make this rtc device target independent

2022-12-30 Thread Bernhard Beschow
Am 29. Dezember 2022 10:58:48 UTC schrieb Thomas Huth : >The only reason for this code being target dependent is the apic-related >code in rtc_policy_slew_deliver_irq(). Since these apic functions are rather >simple, we can easily move them into a new, separate file (apic_irqcount.c) >which