Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-04-20 Thread John Snow
On 4/17/21 6:52 AM, Markus Armbruster wrote: John Snow writes: On 4/16/21 8:44 AM, Markus Armbruster wrote: John Snow writes: It will be an eventual thing, though: I think we need to agree on a style guide document and in that same series, fix up the instances of defying that guide. I

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-04-17 Thread Markus Armbruster
John Snow writes: > On 4/16/21 8:44 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> PEP8's BDFL writes: "For flowing long blocks of text with fewer >>> structural restrictions (docstrings or comments), the line length should >>> be limited to 72 characters." >>> >>> I do not like this

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-04-16 Thread John Snow
On 4/16/21 8:44 AM, Markus Armbruster wrote: John Snow writes: PEP8's BDFL writes: "For flowing long blocks of text with fewer structural restrictions (docstrings or comments), the line length should be limited to 72 characters." I do not like this patch. I have included it explicitly to

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-04-16 Thread Markus Armbruster
John Snow writes: > PEP8's BDFL writes: "For flowing long blocks of text with fewer > structural restrictions (docstrings or comments), the line length should > be limited to 72 characters." > > I do not like this patch. I have included it explicitly to recommend we > do not pay any further heed

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-04-09 Thread John Snow
On 4/9/21 5:33 AM, Markus Armbruster wrote: Daniel P. Berrangé writes: On Fri, Mar 26, 2021 at 04:44:25PM +, Peter Maydell wrote: On Fri, 26 Mar 2021 at 16:33, John Snow wrote: Being less terse about it: Mostly, I don't like how it enforces this column width even for indented

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-04-09 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Mar 26, 2021 at 04:44:25PM +, Peter Maydell wrote: >> On Fri, 26 Mar 2021 at 16:33, John Snow wrote: >> > Being less terse about it: Mostly, I don't like how it enforces this >> > column width even for indented structures. Generally, we claim that 72 >>

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-04-08 Thread Daniel P . Berrangé
On Fri, Mar 26, 2021 at 04:44:25PM +, Peter Maydell wrote: > On Fri, 26 Mar 2021 at 16:33, John Snow wrote: > > Being less terse about it: Mostly, I don't like how it enforces this > > column width even for indented structures. Generally, we claim that 72 > > columns is "comfortable to read"

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-04-08 Thread Markus Armbruster
John Snow writes: > On 3/26/21 2:26 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 3/25/21 11:21 AM, Markus Armbruster wrote: John Snow writes: > PEP8's BDFL writes: "For flowing long blocks of text with fewer > structural restrictions (docstrings or comments),

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-04-08 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 26 Mar 2021 at 16:33, John Snow wrote: >> Being less terse about it: Mostly, I don't like how it enforces this >> column width even for indented structures. Generally, we claim that 72 >> columns is "comfortable to read" and I agree. >> >>

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-03-26 Thread Peter Maydell
On Fri, 26 Mar 2021 at 16:33, John Snow wrote: > Being less terse about it: Mostly, I don't like how it enforces this > column width even for indented structures. Generally, we claim that 72 > columns is "comfortable to read" and I agree. > > However, when we

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-03-26 Thread John Snow
On 3/26/21 2:26 AM, Markus Armbruster wrote: John Snow writes: On 3/25/21 11:21 AM, Markus Armbruster wrote: John Snow writes: PEP8's BDFL writes: "For flowing long blocks of text with fewer structural restrictions (docstrings or comments), the line length should be limited to 72

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-03-26 Thread Markus Armbruster
John Snow writes: > On 3/25/21 11:21 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> PEP8's BDFL writes: "For flowing long blocks of text with fewer >>> structural restrictions (docstrings or comments), the line length should >>> be limited to 72 characters." >>> >>> I do not like

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-03-25 Thread John Snow
On 3/25/21 11:21 AM, Markus Armbruster wrote: John Snow writes: PEP8's BDFL writes: "For flowing long blocks of text with fewer structural restrictions (docstrings or comments), the line length should be limited to 72 characters." I do not like this patch. I have included it explicitly to

Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings

2021-03-25 Thread Markus Armbruster
John Snow writes: > PEP8's BDFL writes: "For flowing long blocks of text with fewer > structural restrictions (docstrings or comments), the line length should > be limited to 72 characters." > > I do not like this patch. I have included it explicitly to recommend we > do not pay any further heed