Re: [PATCH v5 04/18] tests/qtest: migration-test: Avoid using hardcoded /tmp

2022-10-25 Thread Richard Henderson
On 10/26/22 10:44, Bin Meng wrote: ../src/tests/qtest/migration-test.c: In function ‘main’: ../src/tests/qtest/migration-test.c:2484:49: error: ‘%s’ directive argument is null [-Werror=format-overflow=] 2484 | g_test_message("g_dir_make_tmp on path (%s): %s", tmpfs, |

Re: [PATCH v5 04/18] tests/qtest: migration-test: Avoid using hardcoded /tmp

2022-10-25 Thread Bin Meng
On Wed, Oct 26, 2022 at 7:44 AM Richard Henderson wrote: > > On 10/7/22 01:19, Bin Meng wrote: > > From: Bin Meng > > > > This case was written to use hardcoded /tmp directory for temporary > > files. Update to use g_dir_make_tmp() for a portable implementation. > > > > Signed-off-by: Bin Meng

Re: [PATCH v5 04/18] tests/qtest: migration-test: Avoid using hardcoded /tmp

2022-10-25 Thread Richard Henderson
On 10/7/22 01:19, Bin Meng wrote: From: Bin Meng This case was written to use hardcoded /tmp directory for temporary files. Update to use g_dir_make_tmp() for a portable implementation. Signed-off-by: Bin Meng Reviewed-by: Marc-André Lureau --- Changes in v5: - Use g_autoptr(GError)