Re: [PATCH v5 2/2] hw/block/nvme: add the dataset management command

2020-10-22 Thread Klaus Jensen
On Oct 23 07:25, Klaus Jensen wrote: > On Oct 22 23:02, Philippe Mathieu-Daudé wrote: > > On 10/22/20 8:49 PM, Klaus Jensen wrote: > > > -/* support DULBE */ > > > -id_ns->nsfeat |= 0x4; > > > +/* support DULBE and I/O optimization fields */ > > > +id_ns->nsfeat |= (0x4 | 0x10); > >

Re: [PATCH v5 2/2] hw/block/nvme: add the dataset management command

2020-10-22 Thread Klaus Jensen
On Oct 22 23:02, Philippe Mathieu-Daudé wrote: > Hi Klaus, > Hi Philippe, Thanks for your comments! > On 10/22/20 8:49 PM, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Add support for the Dataset Management command and the Deallocate > > attribute. Deallocation results in discards being

Re: [PATCH v5 2/2] hw/block/nvme: add the dataset management command

2020-10-22 Thread Keith Busch
On Thu, Oct 22, 2020 at 11:02:04PM +0200, Philippe Mathieu-Daudé wrote: > On 10/22/20 8:49 PM, Klaus Jensen wrote: > > +static uint16_t nvme_dsm(NvmeCtrl *n, NvmeRequest *req) > > +{ > > +NvmeNamespace *ns = req->ns; > > +NvmeDsmCmd *dsm = (NvmeDsmCmd *) &req->cmd; > > +NvmeDsmRange *ra

Re: [PATCH v5 2/2] hw/block/nvme: add the dataset management command

2020-10-22 Thread Philippe Mathieu-Daudé
Hi Klaus, On 10/22/20 8:49 PM, Klaus Jensen wrote: From: Klaus Jensen Add support for the Dataset Management command and the Deallocate attribute. Deallocation results in discards being sent to the underlying block device. Whether of not the blocks are actually deallocated is affected by the s