Re: [PATCH v5 24/25] qapi: Tighten check whether implicit object type already exists

2024-03-19 Thread John Snow
On Tue, Mar 19, 2024, 12:02 PM Markus Armbruster wrote: > John Snow writes: > > > On Fri, Mar 15, 2024, 11:23 AM Markus Armbruster > wrote: > > > >> Entities with names starting with q_obj_ are implicit object types. > >> Therefore, QAPISchema._make_implicit_object_type()'s .lookup_entity() >

Re: [PATCH v5 24/25] qapi: Tighten check whether implicit object type already exists

2024-03-19 Thread Markus Armbruster
John Snow writes: > On Fri, Mar 15, 2024, 11:23 AM Markus Armbruster wrote: > >> Entities with names starting with q_obj_ are implicit object types. >> Therefore, QAPISchema._make_implicit_object_type()'s .lookup_entity() >> can only return a QAPISchemaObjectType. Assert that. >> >>

Re: [PATCH v5 24/25] qapi: Tighten check whether implicit object type already exists

2024-03-19 Thread John Snow
On Fri, Mar 15, 2024, 11:23 AM Markus Armbruster wrote: > Entities with names starting with q_obj_ are implicit object types. > Therefore, QAPISchema._make_implicit_object_type()'s .lookup_entity() > can only return a QAPISchemaObjectType. Assert that. > > Signed-off-by: Markus Armbruster >

Re: [PATCH v5 24/25] qapi: Tighten check whether implicit object type already exists

2024-03-15 Thread Philippe Mathieu-Daudé
On 15/3/24 16:23, Markus Armbruster wrote: Entities with names starting with q_obj_ are implicit object types. Therefore, QAPISchema._make_implicit_object_type()'s .lookup_entity() can only return a QAPISchemaObjectType. Assert that. Signed-off-by: Markus Armbruster ---