Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-28 Thread Avi Kivity
On 05/24/2012 10:58 PM, Max Filippov wrote: On Thu, May 24, 2012 at 6:26 PM, Avi Kivity a...@redhat.com wrote: On 05/24/2012 05:11 PM, Max Filippov wrote: Not in breakpoint_invalidate as the missing offset was compensated before your commit (well, starting with c2f07f81a2 in fact). I'd say

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-28 Thread Max Filippov
On Mon, May 28, 2012 at 1:34 PM, Avi Kivity a...@redhat.com wrote: On 05/24/2012 10:58 PM, Max Filippov wrote: On Thu, May 24, 2012 at 6:26 PM, Avi Kivity a...@redhat.com wrote: On 05/24/2012 05:11 PM, Max Filippov wrote: Not in breakpoint_invalidate as the missing offset was compensated

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-28 Thread Avi Kivity
On 05/28/2012 02:54 PM, Max Filippov wrote: Right. If the fix is going to be checked in then TeLeMan's original version with '|' is preferable for this reason. I disagree. Whatever we call cpu_get_phys_page_debug() has to either mask out the low bits, or not (I prefer the latter, since it's

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Max Filippov
On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com tb_invalidate_phys_addr has to called with the exact physical address of the breakpoint we add/remove, not just the page's base address. Otherwise we easily fail to flush the right TB.

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Jan Kiszka
On 2012-05-24 07:51, Max Filippov wrote: On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com tb_invalidate_phys_addr has to called with the exact physical address of the breakpoint we add/remove, not just the page's base address.

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Max Filippov
On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 07:51, Max Filippov wrote: On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com tb_invalidate_phys_addr has to called with the exact physical address

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Jan Kiszka
On 2012-05-24 09:08, Max Filippov wrote: On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 07:51, Max Filippov wrote: On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com tb_invalidate_phys_addr has

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Max Filippov
On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:08, Max Filippov wrote: On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 07:51, Max Filippov wrote: On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka jan.kis...@web.de

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Jan Kiszka
On 2012-05-24 09:42, Max Filippov wrote: On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:08, Max Filippov wrote: On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 07:51, Max Filippov wrote: On Thu, May 24, 2012

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Max Filippov
On Thu, May 24, 2012 at 5:26 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:42, Max Filippov wrote: On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:08, Max Filippov wrote: On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Jan Kiszka
On 2012-05-24 11:11, Max Filippov wrote: On Thu, May 24, 2012 at 5:26 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:42, Max Filippov wrote: On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:08, Max Filippov wrote: On Thu, May 24, 2012

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Avi Kivity
On 05/24/2012 05:11 PM, Max Filippov wrote: Not in breakpoint_invalidate as the missing offset was compensated before your commit (well, starting with c2f07f81a2 in fact). I'd say that compensation that you mention ram_addr = (memory_region_get_ram_addr(section.mr) +

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Max Filippov
On Thu, May 24, 2012 at 6:21 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 11:11, Max Filippov wrote: On Thu, May 24, 2012 at 5:26 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:42, Max Filippov wrote: On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Jan Kiszka
On 2012-05-24 11:29, Max Filippov wrote: On Thu, May 24, 2012 at 6:21 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 11:11, Max Filippov wrote: On Thu, May 24, 2012 at 5:26 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-05-24 09:42, Max Filippov wrote: On Thu, May 24, 2012

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Max Filippov
On Thu, May 24, 2012 at 6:26 PM, Avi Kivity a...@redhat.com wrote: On 05/24/2012 05:11 PM, Max Filippov wrote: Not in breakpoint_invalidate as the missing offset was compensated before your commit (well, starting with c2f07f81a2 in fact). I'd say that compensation that you mention    

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-23 Thread Jan Kiszka
On 2012-05-23 23:34, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com tb_invalidate_phys_addr has to called with the exact physical address of the breakpoint we add/remove, not just the page's base address. Otherwise we easily fail to flush the right TB. Regression of 1e7855a558.