Re: [Qemu-devel] [PATCH] configure: save git working tree information in "pkgversion"

2016-06-01 Thread Kashyap Chamarthy
On Tue, May 31, 2016 at 05:04:04PM +0200, Laszlo Ersek wrote: > When building QEMU from a git working tree (either in-tree or > out-of-tree), it is useful to capture the working tree status in the QEMU > binary, for the "-version" option to report. > > Daniel suggested using the "pkgversion"

Re: [Qemu-devel] [PATCH] configure: save git working tree information in "pkgversion"

2016-06-01 Thread Fam Zheng
On Wed, 06/01 10:55, Laszlo Ersek wrote: > (Anyway, this is moot now; I'll happily leave it to Fam! :)) Thanks, I wrote the code before you sent this, so I posted it today anyway. :) Also note that we shouldn't do this at configure time, because between ./configure and make, the tree can be

Re: [Qemu-devel] [PATCH] configure: save git working tree information in "pkgversion"

2016-06-01 Thread Laszlo Ersek
On 05/31/16 19:45, Eric Blake wrote: > On 05/31/2016 11:01 AM, Laszlo Ersek wrote: > Grepping git's Documentation/RelNotes/ directory, I find: - in "1.6.6.txt": the introduction of --dirty - in "1.7.6.4.txt": an apparently important bugfix for --dirty Version 1.7.6.4 of

Re: [Qemu-devel] [PATCH] configure: save git working tree information in "pkgversion"

2016-05-31 Thread Laszlo Ersek
On 05/31/16 19:45, Eric Blake wrote: > On 05/31/2016 11:01 AM, Laszlo Ersek wrote: > Grepping git's Documentation/RelNotes/ directory, I find: - in "1.6.6.txt": the introduction of --dirty - in "1.7.6.4.txt": an apparently important bugfix for --dirty (*) Version

Re: [Qemu-devel] [PATCH] configure: save git working tree information in "pkgversion"

2016-05-31 Thread Eric Blake
On 05/31/2016 11:01 AM, Laszlo Ersek wrote: >>> Grepping git's Documentation/RelNotes/ directory, I find: >>> - in "1.6.6.txt": the introduction of --dirty >>> - in "1.7.6.4.txt": an apparently important bugfix for --dirty >>> >>> Version 1.7.6.4 of git was tagged on Sep 23 2011. >>> >>> Does

Re: [Qemu-devel] [PATCH] configure: save git working tree information in "pkgversion"

2016-05-31 Thread Laszlo Ersek
On 05/31/16 17:43, Daniel P. Berrange wrote: > On Tue, May 31, 2016 at 05:40:38PM +0200, Laszlo Ersek wrote: >> On 05/31/16 17:14, Daniel P. Berrange wrote: >>> On Tue, May 31, 2016 at 05:04:04PM +0200, Laszlo Ersek wrote: When building QEMU from a git working tree (either in-tree or

Re: [Qemu-devel] [PATCH] configure: save git working tree information in "pkgversion"

2016-05-31 Thread Daniel P. Berrange
On Tue, May 31, 2016 at 05:40:38PM +0200, Laszlo Ersek wrote: > On 05/31/16 17:14, Daniel P. Berrange wrote: > > On Tue, May 31, 2016 at 05:04:04PM +0200, Laszlo Ersek wrote: > >> When building QEMU from a git working tree (either in-tree or > >> out-of-tree), it is useful to capture the working

Re: [Qemu-devel] [PATCH] configure: save git working tree information in "pkgversion"

2016-05-31 Thread Laszlo Ersek
On 05/31/16 17:14, Daniel P. Berrange wrote: > On Tue, May 31, 2016 at 05:04:04PM +0200, Laszlo Ersek wrote: >> When building QEMU from a git working tree (either in-tree or >> out-of-tree), it is useful to capture the working tree status in the QEMU >> binary, for the "-version" option to report.

Re: [Qemu-devel] [PATCH] configure: save git working tree information in "pkgversion"

2016-05-31 Thread Daniel P. Berrange
On Tue, May 31, 2016 at 05:04:04PM +0200, Laszlo Ersek wrote: > When building QEMU from a git working tree (either in-tree or > out-of-tree), it is useful to capture the working tree status in the QEMU > binary, for the "-version" option to report. > > Daniel suggested using the "pkgversion"