Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2010-01-08 Thread Anthony Liguori
On 12/29/2009 03:51 PM, H. Peter Anvin wrote: Add generic support for debugging consoles (simple I/O ports which when written to cause debugging output to be written to a target.) The current implementation matches Bochs' port 0xe9, allowing the same debugging code to be used for both Bochs and

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2010-01-02 Thread Kevin O'Connor
On Fri, Jan 01, 2010 at 07:02:59PM -0800, H. Peter Anvin wrote: On 12/30/2009 08:49 AM, Kevin O'Connor wrote: SeaBIOS writes debugging info to port 0x0402. Unfortunately, qemu has to be recompiled in order to display this info. Will your patch enable one to get at the 0x0402 data without

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2010-01-02 Thread H. Peter Anvin
On 01/02/2010 09:53 AM, Kevin O'Connor wrote: On Fri, Jan 01, 2010 at 07:02:59PM -0800, H. Peter Anvin wrote: On 12/30/2009 08:49 AM, Kevin O'Connor wrote: SeaBIOS writes debugging info to port 0x0402. Unfortunately, qemu has to be recompiled in order to display this info. Will your patch

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2010-01-02 Thread François Revol
Makes sense. Either way, it works with my patch looking something like: -chardev stdio,id=seabios \ -device isa-debugcon,iobase=0x402,chardev=seabios ... should do the job. Btw, I once added another method of debug output to ZETA, that was using the low-level protocol used by

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2010-01-01 Thread H. Peter Anvin
On 12/30/2009 08:49 AM, Kevin O'Connor wrote: On Tue, Dec 29, 2009 at 01:51:36PM -0800, H. Peter Anvin wrote: Add generic support for debugging consoles (simple I/O ports which when written to cause debugging output to be written to a target.) The current implementation matches Bochs' port

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2010-01-01 Thread H. Peter Anvin
On 12/30/2009 08:49 AM, Kevin O'Connor wrote: Hi, SeaBIOS writes debugging info to port 0x0402. Unfortunately, qemu has to be recompiled in order to display this info. Will your patch enable one to get at the 0x0402 data without recompiling? -Kevin Incidentally, it's somewhat

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-12-30 Thread Kevin O'Connor
On Tue, Dec 29, 2009 at 01:51:36PM -0800, H. Peter Anvin wrote: Add generic support for debugging consoles (simple I/O ports which when written to cause debugging output to be written to a target.) The current implementation matches Bochs' port 0xe9, allowing the same debugging code to be used

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-12-29 Thread H. Peter Anvin
On 12/29/2009 01:39 PM, H. Peter Anvin wrote: 8 files changed, 187 insertions(+), 1 deletions(-) Sorry everyone, re-sent an old version by mistake. Correctly updated patch will follow. -hpa

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-12-02 Thread malc
On Wed, 2 Dec 2009, H. Peter Anvin wrote: Add generic support for debugging consoles (simple I/O ports which when written to cause debugging output to be written to a target.) The current implementation matches Bochs' port 0xe9, allowing the same debugging code to be used for both Bochs and

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-26 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: On 11/25/09 23:31, H. Peter Anvin wrote: On 11/25/2009 02:26 PM, H. Peter Anvin wrote: As such, I think there is still a place for the simple command line options like -hda, -serial and my proposed -debugcon, in addition to the full-featured

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread Gerd Hoffmann
On 11/25/09 00:05, H. Peter Anvin wrote: On 11/23/2009 12:11 PM, H. Peter Anvin wrote: On 11/23/2009 02:52 AM, Gerd Hoffmann wrote: All not needed. Simply registering as qdev device is enougth. You can then add a debug port like this, without adding new cmd line options: -chardev

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread H. Peter Anvin
Gerd Hoffmann wrote: You can stick it into a config file[1] like this: [chardev debuglog] backend = file path = /path/to/debug.log [device] driver = isa-debugcon chardev = debuglog Then use qemu -readconfig $file. Great... at least in my opinion, one of the things that makes Qemu

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread Gerd Hoffmann
On 11/25/09 19:01, H. Peter Anvin wrote: Gerd Hoffmann wrote: You can stick it into a config file[1] like this: [chardev debuglog] backend = file path = /path/to/debug.log [device] driver = isa-debugcon chardev = debuglog Then use qemu -readconfig $file. Great... at least in my opinion,

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread H. Peter Anvin
On 11/25/2009 02:21 PM, Gerd Hoffmann wrote: You can happily mixup things as you like. Use pure command line. Use pure config file (well, at least is that the plan, it doesn't fully work yet). Mix cmd line switches and config file. Reading multiple config files works just fine too, so

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread H. Peter Anvin
On 11/25/2009 02:26 PM, H. Peter Anvin wrote: As such, I think there is still a place for the simple command line options like -hda, -serial and my proposed -debugcon, in addition to the full-featured connect-anything options and configuration files. That's all. I guess one question is if

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-25 Thread Gerd Hoffmann
On 11/25/09 23:31, H. Peter Anvin wrote: On 11/25/2009 02:26 PM, H. Peter Anvin wrote: As such, I think there is still a place for the simple command line options like -hda, -serial and my proposed -debugcon, in addition to the full-featured connect-anything options and configuration files.

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-24 Thread H. Peter Anvin
On 11/23/2009 12:11 PM, H. Peter Anvin wrote: On 11/23/2009 02:52 AM, Gerd Hoffmann wrote: All not needed. Simply registering as qdev device is enougth. You can then add a debug port like this, without adding new cmd line options: -chardev vc,id=debug -device isa-debugcon,chardev=debug

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-23 Thread Gerd Hoffmann
On 11/20/09 22:33, H. Peter Anvin wrote: +static const uint16_t isa_debugcon_iobase[MAX_DEBUGCON_PORTS] = { 0xe9 }; Not needed here. +if (isa-index == -1) +isa-index = index; +if (isa-index= MAX_DEBUGCON_PORTS) +return -1; +if (isa-iobase == -1) +

Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)

2009-11-23 Thread H. Peter Anvin
On 11/23/2009 02:52 AM, Gerd Hoffmann wrote: All not needed. Simply registering as qdev device is enougth. You can then add a debug port like this, without adding new cmd line options: -chardev vc,id=debug -device isa-debugcon,chardev=debug Adding a second one on a non-default port