Re: [Qemu-devel] [PATCH] hostmem: fix reference to uninit mr

On 10/03/2017 10:36, Peter Xu wrote: > On Fri, Mar 10, 2017 at 10:17:30AM +0100, Peter Maydell wrote: >> On 10 March 2017 at 09:59, Peter Xu wrote: >>> On Fri, Mar 10, 2017 at 09:33:57AM +0100, Paolo Bonzini wrote: On 10/03/2017 05:13, Peter Xu wrote: >

Re: [Qemu-devel] [PATCH] hostmem: fix reference to uninit mr

On Fri, Mar 10, 2017 at 10:17:30AM +0100, Peter Maydell wrote: > On 10 March 2017 at 09:59, Peter Xu wrote: > > On Fri, Mar 10, 2017 at 09:33:57AM +0100, Paolo Bonzini wrote: > >> > >> > >> On 10/03/2017 05:13, Peter Xu wrote: > >> > Trying to get memory region size of an

Re: [Qemu-devel] [PATCH] hostmem: fix reference to uninit mr

On 10/03/2017 09:59, Peter Xu wrote: >> What is the effect of the bug? The idea was to do the initialization >> once only (memory_region_size ought to be 0 when the MR is >> uninitialized; now it is ugly but it made more sense when MemoryRegion >> was just a C struct and not a QOM object). >

Re: [Qemu-devel] [PATCH] hostmem: fix reference to uninit mr

On 10 March 2017 at 09:59, Peter Xu wrote: > On Fri, Mar 10, 2017 at 09:33:57AM +0100, Paolo Bonzini wrote: >> >> >> On 10/03/2017 05:13, Peter Xu wrote: >> > Trying to get memory region size of an uninitialized memory region is >> > probably not a good idea. Let's just do the

Re: [Qemu-devel] [PATCH] hostmem: fix reference to uninit mr

On Fri, Mar 10, 2017 at 09:33:57AM +0100, Paolo Bonzini wrote: > > > On 10/03/2017 05:13, Peter Xu wrote: > > Trying to get memory region size of an uninitialized memory region is > > probably not a good idea. Let's just do the alloc no matter what. > > > > Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH] hostmem: fix reference to uninit mr

On 10/03/2017 05:13, Peter Xu wrote: > Trying to get memory region size of an uninitialized memory region is > probably not a good idea. Let's just do the alloc no matter what. > > Signed-off-by: Peter Xu What is the effect of the bug? The idea was to do the initialization