Re: [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod()

2018-12-14 Thread Philippe Mathieu-Daudé
On 12/14/18 2:30 PM, Thomas Huth wrote: > On 2018-12-14 14:26, Christian Borntraeger wrote: >> >> >> On 14.12.2018 14:23, Thomas Huth wrote: >>> On 2018-12-14 14:15, Christian Borntraeger wrote: On 14.12.2018 14:08, Thomas Huth wrote: > The time2tod() function tries to deal with

Re: [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod()

2018-12-14 Thread Cornelia Huck
On Fri, 14 Dec 2018 14:08:07 +0100 Thomas Huth wrote: > The time2tod() function tries to deal with the 9 uppermost bits in the > time value, but uses the wrong mask for this: 0xff80 should > be used instead of 0xff10 here. I've tweaked this to Since "s390x/tcg: avoid

Re: [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod()

2018-12-14 Thread Thomas Huth
On 2018-12-14 14:26, Christian Borntraeger wrote: > > > On 14.12.2018 14:23, Thomas Huth wrote: >> On 2018-12-14 14:15, Christian Borntraeger wrote: >>> >>> >>> On 14.12.2018 14:08, Thomas Huth wrote: The time2tod() function tries to deal with the 9 uppermost bits in the time value,

Re: [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod()

2018-12-14 Thread Christian Borntraeger
On 14.12.2018 14:23, Thomas Huth wrote: > On 2018-12-14 14:15, Christian Borntraeger wrote: >> >> >> On 14.12.2018 14:08, Thomas Huth wrote: >>> The time2tod() function tries to deal with the 9 uppermost bits in the >>> time value, but uses the wrong mask for this: 0xff80 should >>>

Re: [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod()

2018-12-14 Thread Thomas Huth
On 2018-12-14 14:15, Christian Borntraeger wrote: > > > On 14.12.2018 14:08, Thomas Huth wrote: >> The time2tod() function tries to deal with the 9 uppermost bits in the >> time value, but uses the wrong mask for this: 0xff80 should >> be used instead of 0xff10 here. >>

Re: [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod()

2018-12-14 Thread Christian Borntraeger
On 14.12.2018 14:08, Thomas Huth wrote: > The time2tod() function tries to deal with the 9 uppermost bits in the > time value, but uses the wrong mask for this: 0xff80 should > be used instead of 0xff10 here. > > Fixes: 14055ce53c2d901d826ffad7fb7d6bb8ab46bdfd Can you

Re: [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod()

2018-12-14 Thread David Hildenbrand
On 14.12.18 14:08, Thomas Huth wrote: > The time2tod() function tries to deal with the 9 uppermost bits in the > time value, but uses the wrong mask for this: 0xff80 should > be used instead of 0xff10 here. > > Fixes: 14055ce53c2d901d826ffad7fb7d6bb8ab46bdfd >