Re: [Qemu-devel] [PATCH] ide: fix enum comparison for gcc 4.7

2017-09-20 Thread Mark Cave-Ayland
On 20/09/17 22:33, John Snow wrote: > On 09/20/2017 05:28 PM, Mark Cave-Ayland wrote: >> On 20/09/17 20:41, John Snow wrote: >> >>> Apparently GCC gets bent over comparing enum values against zero. >>> Replace the conditional with something less readable. >>> >>> Signed-off-by: John Snow

Re: [Qemu-devel] [PATCH] ide: fix enum comparison for gcc 4.7

2017-09-20 Thread John Snow
On 09/20/2017 05:28 PM, Mark Cave-Ayland wrote: > On 20/09/17 20:41, John Snow wrote: > >> Apparently GCC gets bent over comparing enum values against zero. >> Replace the conditional with something less readable. >> >> Signed-off-by: John Snow >> --- >> hw/ide/core.c

Re: [Qemu-devel] [PATCH] ide: fix enum comparison for gcc 4.7

2017-09-20 Thread Mark Cave-Ayland
On 20/09/17 20:41, John Snow wrote: > Apparently GCC gets bent over comparing enum values against zero. > Replace the conditional with something less readable. > > Signed-off-by: John Snow > --- > hw/ide/core.c | 2 +- > include/hw/ide/internal.h | 3 +-- > 2

Re: [Qemu-devel] [PATCH] ide: fix enum comparison for gcc 4.7

2017-09-20 Thread Eric Blake
On 09/20/2017 02:41 PM, John Snow wrote: > Apparently GCC gets bent over comparing enum values against zero. > Replace the conditional with something less readable. > > Signed-off-by: John Snow > --- > hw/ide/core.c | 2 +- > include/hw/ide/internal.h | 3 +-- > 2